feat: add vendorfield to list of exportable options#1
Merged
dated merged 5 commits intodated:masterfrom Nov 20, 2021
arkmoon:master
Merged
feat: add vendorfield to list of exportable options#1dated merged 5 commits intodated:masterfrom arkmoon:master
dated merged 5 commits intodated:masterfrom
arkmoon:master
Conversation
dated
requested changes
Nov 19, 2021
| date: true, | ||
| crypto: true, | ||
| fiat: true, | ||
| vendorField: true, |
Owner
There was a problem hiding this comment.
the stored options need to be merged with the default options, otherwise the vendorField toggle won't be visible, something like:
exportOptions () {
const defaultOptions = {
delimiter: ',',
includeHeaders: true,
columns: {
date: true,
crypto: true,
fiat: true,
vendorField: true,
id: true
}
}
const storedOptions = walletApi.storage.get('exportOptions', true)
if (!storedOptions) {
return defaultOptions
}
const columns = {
...defaultOptions.columns,
...storedOptions.columns
}
return {
...defaultOptions,
...storedOptions,
columns
}
},
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
Co-authored-by: Edgar Goetzendorff <hello@dated.fun>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this change for myself, thought I could contribute if this is something anyone else needed.
Helps distinguish transactions that are listed, and allows you to sort by Smartbridge in case you have specific groupings you need to organize your transactions into.
Let me know if I need to make any additional changes @dated