Skip to content

Fix tests #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttiurani merged 3 commits into from
Oct 24, 2024
Merged

Fix tests #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f9fb00
Pin last working version of JS hypercore in tests
cowlicks Oct 24, 2024
39cb206
Fix errors in benches
cowlicks Oct 24, 2024
60015d7
run cargo check on all targets
cowlicks Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ jobs:
components: rustfmt
- name: Run tests
run: |
cargo check --no-default-features --features tokio
cargo check --no-default-features --features tokio,sparse
cargo check --no-default-features --features tokio,sparse,cache
cargo check --no-default-features --features async-std
cargo check --no-default-features --features async-std,sparse
cargo check --no-default-features --features async-std,sparse,cache
cargo check --all-targets --no-default-features --features tokio
cargo check --all-targets --no-default-features --features tokio,sparse
cargo check --all-targets --no-default-features --features tokio,sparse,cache
cargo check --all-targets --no-default-features --features async-std
cargo check --all-targets --no-default-features --features async-std,sparse
cargo check --all-targets --no-default-features --features async-std,sparse,cache
cargo test --no-default-features --features js_interop_tests,tokio
cargo test --no-default-features --features js_interop_tests,tokio,sparse
cargo test --no-default-features --features js_interop_tests,tokio,sparse,cache
Expand All @@ -57,12 +57,12 @@ jobs:
components: rustfmt
- name: Run tests
run: |
cargo check --no-default-features --features tokio
cargo check --no-default-features --features tokio,sparse
cargo check --no-default-features --features tokio,sparse,cache
cargo check --no-default-features --features async-std
cargo check --no-default-features --features async-std,sparse
cargo check --no-default-features --features async-std,sparse,cache
cargo check --all-targets --no-default-features --features tokio
cargo check --all-targets --no-default-features --features tokio,sparse
cargo check --all-targets --no-default-features --features tokio,sparse,cache
cargo check --all-targets --no-default-features --features async-std
cargo check --all-targets --no-default-features --features async-std,sparse
cargo check --all-targets --no-default-features --features async-std,sparse,cache
cargo test --no-default-features --features tokio
cargo test --no-default-features --features tokio,sparse
cargo test --no-default-features --features tokio,sparse,cache
Expand All @@ -82,12 +82,12 @@ jobs:
components: rustfmt
- name: Run tests
run: |
cargo check --no-default-features --features tokio
cargo check --no-default-features --features tokio,sparse
cargo check --no-default-features --features tokio,sparse,cache
cargo check --no-default-features --features async-std
cargo check --no-default-features --features async-std,sparse
cargo check --no-default-features --features async-std,sparse,cache
cargo check --all-targets --no-default-features --features tokio
cargo check --all-targets --no-default-features --features tokio,sparse
cargo check --all-targets --no-default-features --features tokio,sparse,cache
cargo check --all-targets --no-default-features --features async-std
cargo check --all-targets --no-default-features --features async-std,sparse
cargo check --all-targets --no-default-features --features async-std,sparse,cache
cargo test --no-default-features --features js_interop_tests,tokio
cargo test --no-default-features --features js_interop_tests,tokio,sparse
cargo test --no-default-features --features js_interop_tests,tokio,sparse,cache
Expand Down
4 changes: 2 additions & 2 deletions benches/memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ async fn create_hypercore(page_size: usize) -> Result<Hypercore, HypercoreError>
let storage = Storage::open(
|_| {
Box::pin(async move {
Ok(Box::new(RandomAccessMemory::new(page_size)) as Box<dyn StorageTraits>)
Ok(Box::new(RandomAccessMemory::new(page_size)) as Box<dyn StorageTraits + Send>)
})
},
false,
Expand All @@ -44,7 +44,7 @@ async fn create_hypercore(page_size: usize) -> Result<Hypercore, HypercoreError>
let storage = Storage::open(
|_| {
Box::pin(async move {
Ok(Box::new(RandomAccessMemory::new(page_size)) as Box<dyn StorageTraits>)
Ok(Box::new(RandomAccessMemory::new(page_size)) as Box<dyn StorageTraits + Send>)
})
},
false,
Expand Down
2 changes: 1 addition & 1 deletion tests/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"step": "node interop.js"
},
"dependencies": {
"hypercore": "^10"
"hypercore": "10.31.12"
}
}