feat: Change encode/decode signatures to improve error handling#6
Open
okdistribute wants to merge 2 commits intomasterfrom
Open
feat: Change encode/decode signatures to improve error handling#6okdistribute wants to merge 2 commits intomasterfrom
okdistribute wants to merge 2 commits intomasterfrom
Conversation
Open
Frando
requested changes
Mar 17, 2021
Member
Frando
left a comment
Frando
left a comment
There was a problem hiding this comment.
Hi! The signatures of the new methods look good to me, and now more panic! 😄
I left a few small comments, the main one being that I'd propose to skip the failure dependency and just use a simple custom error type. Otherwise it's good to go for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change, will bump to 2.0.0
Fixes #5, see there for discussion.