Skip to content

Add a scheduled GitHub Action to check upstream version#275

Merged
daviddrysdale merged 1 commit intodaviddrysdale:devfrom
jlaine:check-upstream-version
Jul 24, 2023
Merged

Add a scheduled GitHub Action to check upstream version#275
daviddrysdale merged 1 commit intodaviddrysdale:devfrom
jlaine:check-upstream-version

Conversation

@jlaine
Copy link
Copy Markdown
Contributor

@jlaine jlaine commented Jul 24, 2023

Twice a day, a scheduled action checks the latest upstream release and compares it to the current phonenumbers version. The check succeeds if and only if the two versions match.

See #273

@jlaine
Copy link
Copy Markdown
Contributor Author

jlaine commented Jul 24, 2023

Notes:

  • I don't know what your "home" timezone is, so feel free to suggest a more convenient time
  • I have included the "workflow_dispatch" trigger so the action can be run manually
  • So far I've only witness manually triggered runs, I'm not sure if this is because I'm operating on a fork

Here is a scheduled run of the action:

https://github.com/jlaine/python-phonenumbers/actions/runs/5642100157

Copy link
Copy Markdown
Owner

@daviddrysdale daviddrysdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you – just a couple of minor nits.

Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread .github/workflows/upstream.yml Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread .github/workflows/upstream.yml Outdated
Comment thread .github/workflows/upstream.yml Outdated
Comment thread .github/workflows/upstream.yml Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread tools/python/checkupstreamversion.py Outdated
Comment thread .github/workflows/upstream.yml
Twice a day, a scheduled action checks the latest upstream release and
compares it to the current `phonenumbers` version. The check succeeds if
and only if the two versions match.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@jlaine
Copy link
Copy Markdown
Contributor Author

jlaine commented Jul 24, 2023

Thanks to @AA-Turner for all the suggested changes!

I think I've addressed all the requested changes, I'd still value your input on whether you want to keep the workflow_dispatch.

@daviddrysdale daviddrysdale merged commit b41129d into daviddrysdale:dev Jul 24, 2023
@daviddrysdale
Copy link
Copy Markdown
Owner

Thanks @jlaine and @AA-Turner !

@jlaine
Copy link
Copy Markdown
Contributor Author

jlaine commented Jul 24, 2023

Oh crud. The if github.repository_owner == "daviddrysdale" broke the build:

https://github.com/daviddrysdale/python-phonenumbers/actions/runs/5644422744

@daviddrysdale
Copy link
Copy Markdown
Owner

Yeah, it seems that an if: line uses GitHub expression syntax, not YAML syntax, and so strings need to be single quoted. No worries, easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants