Add a scheduled GitHub Action to check upstream version#275
Merged
daviddrysdale merged 1 commit intodaviddrysdale:devfrom Jul 24, 2023
jlaine:check-upstream-version
Merged
Add a scheduled GitHub Action to check upstream version#275daviddrysdale merged 1 commit intodaviddrysdale:devfrom jlaine:check-upstream-version
daviddrysdale merged 1 commit intodaviddrysdale:devfrom
jlaine:check-upstream-version
Conversation
Contributor
Author
|
Notes:
Here is a scheduled run of the action: https://github.com/jlaine/python-phonenumbers/actions/runs/5642100157 |
Owner
daviddrysdale
left a comment
There was a problem hiding this comment.
Looks good, thank you – just a couple of minor nits.
AA-Turner
reviewed
Jul 24, 2023
AA-Turner
reviewed
Jul 24, 2023
Twice a day, a scheduled action checks the latest upstream release and compares it to the current `phonenumbers` version. The check succeeds if and only if the two versions match. Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Contributor
Author
|
Thanks to @AA-Turner for all the suggested changes! I think I've addressed all the requested changes, I'd still value your input on whether you want to keep the |
daviddrysdale
approved these changes
Jul 24, 2023
Owner
|
Thanks @jlaine and @AA-Turner ! |
Contributor
Author
|
Oh crud. The https://github.com/daviddrysdale/python-phonenumbers/actions/runs/5644422744 |
Owner
|
Yeah, it seems that an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twice a day, a scheduled action checks the latest upstream release and compares it to the current
phonenumbersversion. The check succeeds if and only if the two versions match.See #273