Skip to content

Fix crash if valueList as an empty entry #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidhamann merged 3 commits into from
Jan 22, 2024
Merged

Fix crash if valueList as an empty entry #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8249234
fix listValue null displayname
LeJeko Jan 20, 2024
40d3a36
bump version
LeJeko Jan 20, 2024
1c36ac7
Merge pull request #7 from LeJeko/fix-valueList
LeJeko Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fmrest/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,9 +875,10 @@ def get_value_list_values(self, name: str, layout: Optional[str] = None) -> List

for vlist in value_lists:
if vlist['name'] == name:
values += [(v['value'], v['displayValue']) for v in vlist['values']]
values += [(v['value'], v.get('displayValue', '')) for v in vlist['values']]
break


return values

def _call_filemaker(self, method: str, path: str,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setup(
name='python-fmrest',
version='1.7.0',
version='1.7.1',
python_requires='>=3.6',
author='David Hamann',
author_email='dh@davidhamann.de',
Expand Down