Skip to content

Create pull request template#24

Merged
jawrainey merged 1 commit intomasterfrom
pr_template
May 6, 2020
Merged

Create pull request template#24
jawrainey merged 1 commit intomasterfrom
pr_template

Conversation

@davidverweij
Copy link
Copy Markdown
Owner

@davidverweij davidverweij commented May 6, 2020 •
edited
Loading

What Changed (and why)?

  1. Added PR template in the hidden .github folder based on online found templates and @jawrainey use in Upgrade to Python 3.8 (from 2.7) #4. This should automatically populate the text field when doing a PR.

How to test Changes

  1. No testing to be done.

Please review @jawrainey

@davidverweij
Create pull request template
dd095a2 
Based on online found templates and @jawrainey use in #4
@davidverweij davidverweij added the documentation Improvements or additions to documentation label May 6, 2020
@davidverweij davidverweij requested a review from jawrainey May 6, 2020 08:47
@jawrainey
Copy link
Copy Markdown
Collaborator

jawrainey commented May 6, 2020

Great idea. Perfection 🏅

@jawrainey jawrainey merged commit f474cd0 into master May 6, 2020
@davidverweij davidverweij deleted the pr_template branch May 6, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jawrainey jawrainey Awaiting requested review from jawrainey

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidverweij @jawrainey