Fix: Potential Vulnerability in Cloned Function#3058
Merged
davisking merged 1 commit intodavisking:masterfrom Feb 27, 2025
Merged
Fix: Potential Vulnerability in Cloned Function#3058davisking merged 1 commit intodavisking:masterfrom
davisking merged 1 commit intodavisking:masterfrom
Conversation
Throw an error when image width or height is 0. Fixes mozilla/mozjpeg#140, closes davisking#7.
Owner
|
Nice, thanks for the fix. |
Contributor
Author
|
Hi @davisking, thanks for merging my PR. Just want to let you know that I plan to report this as a CVE. Let me know if you have any concern! |
davisking
pushed a commit
to kSkip/dlib
that referenced
this pull request
Apr 19, 2025
Throw an error when image width or height is 0. Fixes mozilla/mozjpeg#140, closes davisking#7.
|
What is the point of this bug fix, in Line 365, the size of image is already checked before the changed line? |
Owner
|
Heh yeah, I just verified that the same patch was in the upstream repo. But that's a slightly different version of the code and it's not needed here. No worries though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security vulnerability in start_input_tga() that was cloned from libjpeg-turbo but did not receive the security patch. The original issue was reported and fixed under libjpeg-turbo/libjpeg-turbo@82923eb.
This PR applies the same patch to eliminate the vulnerability.
References
https://nvd.nist.gov/vuln/detail/CVE-2018-11212
libjpeg-turbo/libjpeg-turbo@82923eb