Skip to content

Conversation

@mojafa
Copy link
Contributor

@mojafa mojafa commented Dec 22, 2024

added a step on the github actions to check for open prs and enforce policy for one open pr per contributor

…enforce policy for one open pr per contributor

Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
@nibzard nibzard requested a review from zzorica January 15, 2025 17:02
@nibzard
Copy link
Contributor

nibzard commented Jan 15, 2025

@zzorica could you please check this action when you find time, not a priority

@zzorica
Copy link

zzorica commented Jan 31, 2025

Hi @mojafa @nkkko

Looks ok but one thing that would be good to change, and that is to not use ::set-output but use GITHUB_OUTPUT. Former is deprecated. For example:

echo "::set-output name=related-to-existing-pr::true"

into

echo "related_to_existing_pr=true" >> $GITHUB_OUTPUT

Also not sure how gh pr list would work in forked repos. That always confuses me :-) But we can see that in RL scenario.

@mojafa
Copy link
Contributor Author

mojafa commented Jan 31, 2025

@zzorica on it

@mojafa
Copy link
Contributor Author

mojafa commented Jan 31, 2025

@nkkko @zzorica Here is the result for an attempt to open multiple PRs.
Screenshot 2025-01-31 at 22 24 32

Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
@zzorica
Copy link

zzorica commented Jan 31, 2025

I see you figured out that permission was the issue on your example. The issue I see now is markdownlint step. Will check more details tomorrow as Im not sure what you changed here and why...

@mojafa
Copy link
Contributor Author

mojafa commented Jan 31, 2025

I'm looking into it now. The markdown issue. Will update once im done, technically if all passes.

Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
Signed-off-by: mojafa <jmohsa@gmail.com>
@mojafa
Copy link
Contributor Author

mojafa commented Jan 31, 2025

@nkkko pr-policy had passed, facing issues on markdown, used cli and prettier to clean them up, but looks like it's causing a conflict.

Please check!

Signed-off-by: mojafa <jmohsa@gmail.com>
@mojafa mojafa closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants