feat: expose connectError event with HTTP status for transport override support#2821
Merged
feat: expose connectError event with HTTP status for transport override support#2821
Conversation
barak007
approved these changes
Feb 4, 2026
cylon324
approved these changes
Feb 4, 2026
Contributor
Author
there is no infra to check actual socket behavior and cause connection errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes connection error information for
ws-client-hostthrough a newconnectErrorevent.Changes in this PR:
connectErrorevent to the WsClientHost that reports astatusnumberconnect_errorhandler fromoncetoon, allowing multiple error events to be emitted during connection retriessocketServerOptionsinlaunchEngineHttpServerso they are applied aftertransports, enabling them to override transport defaultsNote that these changes do not modify the default
transportsconfiguration. As a result, the currently reported connection error status will be0. To surface a meaningful status code, Socket.IO must prioritizepollingoverwebsocket, ensuring the connection begins with polling before upgrading to WebSocket.