Conversation
dazzle-jukka
approved these changes
Dec 13, 2021
Collaborator
dazzle-jukka
left a comment
dazzle-jukka
left a comment
There was a problem hiding this comment.
LGTM 👍 Left a couple of comments
| { | ||
| public interface ISocketOptions | ||
| { | ||
| public void AddSubProtocol(string protocol); |
Collaborator
There was a problem hiding this comment.
I don't think public is needed inside the interface 🙂
Runtime/SimpleGraphQL/HttpUtils.cs
Outdated
|
|
||
| public class ClientWebSocketOptionsWrapper : IWebSocket.ISocketOptions | ||
| { | ||
| ClientWebSocketOptions o; |
Collaborator
There was a problem hiding this comment.
Please use descriptive names 🙂
Runtime/SimpleGraphQL/HttpUtils.cs
Outdated
|
|
||
| public ClientWebSocketOptionsWrapper(ClientWebSocketOptions o_) | ||
| { | ||
| o = o_; |
Collaborator
There was a problem hiding this comment.
_ could be dropped from the parameter name, e.g. this.o = o
Runtime/SimpleGraphQL/HttpUtils.cs
Outdated
|
|
||
| Uri uri = new Uri(url); | ||
| _webSocket = new ClientWebSocket(); | ||
| if (ws != null) { |
Collaborator
There was a problem hiding this comment.
{should be on a new line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.