Use options.cwd when loading plugins#618
Merged
wzrdtales merged 1 commit intodb-migrate:masterfrom May 11, 2019
Merged
Conversation
When loading plugins, ```options.cwd``` is ignored in favour of ```process.cwd()```. This results in hideous errors when one specifies cwd in the ```options``` which is different from ```process.cwd()```
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
wzrdtales
pushed a commit
that referenced
this pull request
Jun 8, 2019
When loading plugins, ```options.cwd``` is ignored in favour of ```process.cwd()```. This results in hideous errors when one specifies cwd in the ```options``` which is different from ```process.cwd()```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading plugins,
options.cwdis ignored in favour ofprocess.cwd(). This results in hideous errors when one specifies cwd in theoptionswhich is different fromprocess.cwd()