Preliminary work for a future change in outputting results that uses less memory #780
Conversation
meeuw
force-pushed
the
feature/output_formatter_generator
branch
9 times, most recently
from
2581140 to
0afbe56
Compare
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
==========================================
+ Coverage 82.85% 82.91% +0.05%
==========================================
Files 20 20
Lines 2321 2329 +8
==========================================
+ Hits 1923 1931 +8
Misses 398 398
Continue to review full report at Codecov.
|
meeuw
force-pushed
the
feature/output_formatter_generator
branch
from
0afbe56 to
cf7e68c
Compare
|
@meeuw Is this WIP or done? |
meeuw
force-pushed
the
feature/output_formatter_generator
branch
from
cf7e68c to
483895b
Compare
|
done, please review and merge. |
j-bennet
left a comment
j-bennet
left a comment
There was a problem hiding this comment.
I'm a little confused by the first text_type check. Hope you can help me figure out what's going on.
Thanks!
| * Don't quote identifiers that are non-reserved keywords. (Thanks: `Joakim Koljonen`_) | ||
| * Remove the ``...`` in the continuation prompt and use empty space instead. (Thanks: `Amjith Ramanujam`_) | ||
| * Add \conninfo and handle more parameters with \c (issue #716) (Thanks: `François Pietka`_) | ||
| * Preliminary work for a future change in outputting results that uses less memory. (Thanks: `Dick Marinus`_) |
There was a problem hiding this comment.
This should be in "Internal changes" section.
| formatted = formatter.format_output(rows, headers, **output_kwargs) | ||
| first_line = formatted[:formatted.find('\n')] | ||
|
|
||
| if isinstance(formatted, (text_type)): |
There was a problem hiding this comment.
Can this be anything other than text_type? If yes, what happens in that case?
There was a problem hiding this comment.
This is exactly what this PR is about (you have a sharp eye!). In the next version of cli_helpers a generator will be outputted from format_output which yields lines without newline characters.
When this new version of cli_helpers is released these lines can be removed. See dbcli/cli_helpers#13
meeuw
force-pushed
the
feature/output_formatter_generator
branch
from
483895b to
d2ecbde
Compare
|
👍 |
Description
Preliminary work for a future change in outputting results that uses less memory
Checklist
changelog.md.