Skip to content

Conversation

@dbeatty10
Copy link
Owner

History

datafold#22 was an initial attempt at unblocking data-diff --dbt for DuckDB. This is a second attempt.

Enabling 3-part fully-qualified names (FQN)

This 2nd attempt enables all of the following:

  • 1-part paths
  • 2-part paths
  • 3-part paths

The latter is especially important for the following reasons:

  1. DuckDB 0.7.0 adds support for attaching multiple databases
  2. It appears that prior to DuckDB 0.7.0, supplying a database/catalog in a 3-part path is allowed and handled gracefully

Implementation details

Both DuckDB and Redshift have lots of similarities with PostgreSQL. So for this implementation, I just copied-pasted two methods from redshift to duckdb:

  1. select_table_schema
  2. _normalize_table_path

@dbeatty10 dbeatty10 marked this pull request as ready for review February 24, 2023 15:19
@dbeatty10 dbeatty10 merged commit d75cb4b into master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants