feat(m17): enhance parrot mode and fix @ALL routing#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M17 Protocol Enhancements and Fixes
Overview
This PR implements significant improvements and fixes for the M17 protocol handling in
urfd.Key Changes
1. @ALL Receive Fix ("Contextual Broadcast")
@ALLpackets were being rejected due to strict callsign validation ('@' not allowed) and empty module information frommvoice.CCallsign::IsValidM17to allow@and#prefixes.M17Protocolto detect@ALLwith an empty module and force the target module to the client's current module.@ALL.2. Parrot Mode Implementation
PARROT,M17-PARROT,#PARROT), matchingmrefdfuzzy matching behavior.isParrotthat caused module lookup errors.3. Stream Timeout Fix
CProtocol::CheckStreamsTimeout()ensuring idle streams are closed properly.4. Packet Mode (SMS)
Verification
mvoiceclient (verified Parrot functionality and error handling).