Skip to content

Conversation

@clkao
Copy link
Contributor

@clkao clkao commented Nov 6, 2025

This PR depends on #42 for the plugin system. The plugin does two things:

  1. makes "last known & working" production dbt artifacts available in target-base for agents to consume.
  2. copies the artifacts before/after to the experiments folder for further analysis.

clkao and others added 26 commits November 7, 2025 17:44
…owers before we have proper hooks for post-agent-install

Also have git otherwise Claude get pretty confused.
Remove the --use-mcp CLI flag and use_mcp parameter throughout the codebase.
The used_mcp field in trial results is now derived from whether the dbt-mcp
plugin actually ran during the trial, determined by PluginRegistry.did_plugin_run().

Changes:
- Remove --use-mcp from both CLI commands (ade run and run_harness.py)
- Remove use_mcp parameter from Harness and AbstractInstalledAgent
- Add plugins_run tracking set to PluginRegistry
- Add did_plugin_run() method to check if specific plugin executed
- Update trial result creation to derive used_mcp from plugin execution
- Add validation to error out when non-existing plugins are specified

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
The SetupOrchestrator created during trial execution was missing the
enabled_plugins parameter, causing plugins to never run. Store
enabled_plugins as instance variable and pass to both orchestrator
instantiations.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Creates baseline manifest.json and catalog.json in target-base directory
for use by tools like recce

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Implements plugin that generates baseline dbt artifacts in post_setup phase.
Copies and executes generation script in container.

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Makes dbt-artifacts plugin available via --plugins flag

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Tasks intentionally break dbt projects during setup, so artifacts must be
generated before setup.sh runs to capture the working baseline state
Script now installs dbt dependencies before running dbt compile,
since pre_setup phase runs before setup.sh which normally installs deps
- Generates final artifacts after agent execution with dbt docs generate
- Archives both baseline (target-base) and final (target) artifacts to experiments folder
- Creates dbt_artifacts/baseline/ and dbt_artifacts/final/ directories
- Copies manifest.json and catalog.json from both directories
Simpler implementation using docker cp CLI command instead of
extracting from tar archives via Docker SDK
@clkao clkao force-pushed the feature/dbt-artifacts-plugin branch from 9d86166 to 4502988 Compare November 8, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant