Warning despite Signed-off-by:?

[dscho]

I just got a red x from the DCO bot on this commit: git-for-windows/build-extra@1bafa00

However, this commit has a Signed-off-by: line, with my correct information...

[hiimbex]

Thanks for this issue @dscho. If I'm being honest, I have no idea why the bot is failing on that commit. I'm curious if you have any other instances of this occurring or has it become a consistent issue on that repo?

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

[dscho]

Sorry for the long silence, yes, it is still relevant. See for example https://github.com/git-for-windows/build-extra/commits/fd28a43a8e93dce2887a2b574e05e696767308e0. I committed this, with my Sign-off, and pushed this, and DCO bot marked it as faulty...

[dscho]

The really curious thing is that this was a commit that was pushed directly. No PR involved. I do not even see code in https://github.com/probot/dco/blob/master/index.js that would suggest that the DCO bot should kick in when I push directly.

GitHub

probot/dco

dco - GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests

[dscho]

Also, when I look at https://github.com/git-for-windows/build-extra/commits/4aec8bd815c4e35a295d6c21902b215015d11bcb (Of course, just the top commit, but the commit status is only shown in the "commits" version of the URL, not in the "commit" version of the URL), I see that it is a merge. Yet this code seems to not kick in (because the DCO bot marks this with a red X): https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/lib/dco.js#L16

GitHub

git-for-windows/build-extra

build-extra - Additional files and scripts to help build Git for Windows on MSYS2.

[dscho]

I figured it out!!!!

The problem is completely obscure, and it is a bug in the DCO bot.

We have a long-running PR here: git-for-windows/build-extra#159. It will eventually be integrated, but it still needs work, and for that it needs time from my side. And sign-offs, see the commits here: https://github.com/git-for-windows/build-extra/pull/159/commits

However.

DCO bot always puts its commit status onto the newest commit of the master branch! That's why I am always surprised, as it tells me the wrong thing. It should update the commit status of the PR branch instead.

GitHub

Integration tests by albfan · Pull Request #159 · git-for-windows/build-extra

Based on https://github.com/chriscool/sharness (testsuite alike git uses) this test suite check the integrity of extras added to git-for-windows First test check the comparison as text from open do...

[dscho]

Okay, my guess is that something goes wrong with the createStatus() call due to the missing owner and repo parameters. In particular, I think that this code:

https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/index.js#L24-L27

needs to be adjusted to read somewhat like this:

    const params = Object.assign({
      owner: pr.repository.owner.login,
      repo: pr.repository.name,
      sha: pr.head.sha,
      context: 'DCO'
    }, dcoParams)

However, I have no way to test this, nor to verify my hunch that this is what is going wrong.

[dscho]

@hiimbex do you have any way to verify this hunch?

[dscho]

Please note that I just added a status to git-for-windows/build-extra@2a305b1 manually (before I realized that commit statuses cannot be removed, like, ever). It is not a status added by DCO bot, though, as you can easily verify by running curl https://api.github.com/repos/git-for-windows/build-extra/statuses/2a305b131ffa3c005a983906171d7b5ec6eae813.

[hiimbex]

Hi @dscho! Thanks for all the debugging!

Unfortunately when we make the API call here: https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/index.js#L29

we are actually wrapping those params in context.repo() which utilizes an internal probot API to return the owner and repo params. Without those params, the app wouldn't work at all. Additionally sha: pr.head.sha makes sure the status is correctly referenced to the specific commit that was pushed. The DCO also only works on pull request events; see: https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/index.js#L5

I'm having a bit of trouble following what some of your links are supposed to be pointing me towards. Do you think you could try summarizing again what exactly the problem you're facing is? I'd also appreciate if you could link me to commits via a pull request instead of in the repo generally. Thanks!

[dscho]

@hiimbex here's your summary:

There is a long-running PR in the repository in question: git-for-windows/build-extra#159

This PR consists of four commits that all lack the SOB line.

Whenever master advances, for some reason the commit status is updated on master's tip commit instead of the tip commit of said PR.
</summary>

I have no concrete idea what is going wrong there (although I offered some conjecture, and I even tried to verify it, resulting in that "DCO-test" "Check" that you can see at that PR, which is not DCO's doing but mine).

After reflecting on it, I could imagine that maybe for "synchronize" events, the pr.head.sha is not even set. Or maybe it is not set for this PR, as it was opened way before I activated DCO bot on that repository.

Maybe you could have a look? Owners of bots can see the latest delivered payloads. And the latest "synchronize" event was delivered some 6h ago, for commit git-for-windows/build-extra@f1fd01a (which is also marked as broken by DCO bot, most likely due to mislabeling master's tip commit instead of the tip commit of refs/pull/159/head).

[hiimbex]

This PR consists of four commits that all lack the SOB line.

Ok I can see that and that makes sense. But that PR should have no effect on other PRs.

If you look at these screenshot, it appears to me as though you are doing some kind of squash/merging ? on your PRs, since the top one clearly does not have a sign off in the commit, even though I see it in the PR.

It appears the app is failing on that merge for some reason, even though I wouldn't expect the bot to run on that commit at all. You can see in this example on this repo:

from #82, that if you click on the checks run, the DCO doesn't even run on the merger commit, since it's not a pull request being opened or synchronized.

I'm honestly very confused how this behavior is happening. Can you tell me if you have any custom set-up on the repo, like the way you use statuses or how you usually merge PRs?

[dscho]

If you look at these screenshot, it appears to me as though you are doing some kind of squash/merging ?

This is the regular "Merge" button of GitHub. We use the message as suggested, without adding our own signoff.

Please note that nothing is squashed, as can be seen here:

It appears the app is failing on that merge for some reason

I really, really doubt that. Have a look at the current tip of our master:

It has that red X, even if the tip commit has a SOB line:

It is also very funny that the check now talks about lemons:

Please note that this is a new one. The last DCO check to not talk about lemons was the one on this commit:

Also note that the only commit that has no DCO check is this one: git-for-windows/build-extra@10b58d8. It is easily explained thusly: that commit was never the tip of master. It was committed locally, then git-for-windows/build-extra@7be1ebf was committed locally, and then the result was pushed.

You can see in this example on this repo:
screen shot 2018-08-21 at 11 20 38 am
from #82, that if you click on the checks run, the DCO doesn't even run on the merger commit, since it's not a pull request being opened or synchronized.

I saw this in the source code, too. DCO bot really runs on the PR's commits.

However, I am rather convinced that DCO bot fails, for some reason, to attach the check onto the correct commits in this PR: git-for-windows/build-extra#159. If you care to look via the REST API, you will see that DCO bot never, ever put a commit status there. I did, to test with what I thought might have been the parameters used by the DCO bot.

Please note, though, that DCO bot never, ever marked the tip commit of git-for-windows/build-extra#159. Not a single time.

But whenever master advances, DCO bot marks the tip of master as failed.

Which makes me think that it must be that PR that triggers the bug.

Really, what other option is there? DCO bot gets triggered when a PR is opened, or when it is synchronized (which also happens when master advances, not only when new commits are pushed to that PR).

So we know that DCO bot gets triggered because of git-for-windows/build-extra#159.

We also know that it never put a check (or commit status) to the tip commit of git-for-windows/build-extra#159. Not a single time.

However, we know that DCO bot did attach a check (or commit status) to the tip commit of master whenever it advanced.

I'm honestly very confused how this behavior is happening. Can you tell me if you have any custom set-up on the repo, like the way you use statuses or how you usually merge PRs?

Me, too.

However, I think I already suggested something really important.

You see, GitHub apps have this wonderful page where you can see the last delivered events. Now, I don't know how far back it goes, but I know that there must have been a "synchronize" event being delivered to the DCO bot a little after Tue Aug 21 22:36:39 2018 +0200 (which is when I committed that tip commit, and I pushed it probably within 5 minutes or so).

You can now look at that delivered event and see exactly the payload.

My suspicion is that something in that payload triggers that bug. I.e. there must be something violating DCO bot's assumptions.

I do not know what could possibly go wrong, though, as https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/index.js#L25 specifically tries to use pr.head.sha, which is also used in https://github.com/probot/dco/blob/d9b75c45ab23b1ddc62602086bb53c8fe4ce8af7/index.js#L17-L20 (which I assume works alright, but that assumption might already be incorrect).

It is of course also possible that something else goes horribly wrong and that my analysis is incorrect, seeing as the message we get now seems to indicate a problem with PR git-for-windows/build-extra#181 (which indeed has an incorrect Signed-off-by: line), but that PR is long closed.

Sadly, I cannot analyze the payloads delivered to DCO bot because I don't own that app, and in contrast to webhooks, the GitHub Apps page in the settings does not let me see what was/was not delivered.

However, a thought just occurred to me. I do have a webhook registered for GMaster MergeDroid, so I can see what payloads should have been delivered also to DCO bot.

And this is where things get interesting.

I get this:

In other words, I was totally, utterly wrong on my assessment. Neither git-for-windows/build-extra#181 nor git-for-windows/build-extra#159 were a problem (and the fact that the latter never got a commit status assigned by DCO bot is most likely a red herring, and is instead rooted in the fact that I may have installed the DCO bot into the repository only after that PR was last updated), but instead git-for-windows/build-extra#127. Which does not even exist anymore.

Now, the PR title "Master" suggests that this was spam, corroborating evidence being that the user's account page also does not exist anymore.

So now I guess what is happening is this: the PR 127 was deleted, but incompletely, and its tip commit was set to master (or left there), so whenever master advances, DCO bot is asked to look at the commits between the silent-install branch (which is that PR's base branch, according to the payload) and the master branch.

Now, I think that the root cause of this problem is not even a bug in DCO bot, but an inconsistency in the data: that payload should never have been delivered, not after PR 127 was deleted.

I don't really know whether there is anything that DCO bot can do to detect this situation... Here is the full payload for your pleasure:

{
  "action": "synchronize",
  "number": 127,
  "pull_request": {
    "url": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127",
    "id": 81277282,
    "node_id": "MDExOlB1bGxSZXF1ZXN0ODEyNzcyODI=",
    "html_url": "https://github.com/git-for-windows/build-extra/pull/127",
    "diff_url": "https://github.com/git-for-windows/build-extra/pull/127.diff",
    "patch_url": "https://github.com/git-for-windows/build-extra/pull/127.patch",
    "issue_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/127",
    "number": 127,
    "state": "open",
    "locked": false,
    "title": "Master",
    "user": {
      "login": "harpagan01",
      "id": 20671662,
      "node_id": "MDQ6VXNlcjIwNjcxNjYy",
      "avatar_url": "https://avatars0.githubusercontent.com/u/20671662?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/harpagan01",
      "html_url": "https://github.com/harpagan01",
      "followers_url": "https://api.github.com/users/harpagan01/followers",
      "following_url": "https://api.github.com/users/harpagan01/following{/other_user}",
      "gists_url": "https://api.github.com/users/harpagan01/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/harpagan01/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/harpagan01/subscriptions",
      "organizations_url": "https://api.github.com/users/harpagan01/orgs",
      "repos_url": "https://api.github.com/users/harpagan01/repos",
      "events_url": "https://api.github.com/users/harpagan01/events{/privacy}",
      "received_events_url": "https://api.github.com/users/harpagan01/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": null,
    "created_at": "2016-08-15T07:07:31Z",
    "updated_at": "2018-08-21T20:38:11Z",
    "closed_at": null,
    "merged_at": null,
    "merge_commit_sha": null,
    "assignee": null,
    "assignees": [

    ],
    "requested_reviewers": [

    ],
    "requested_teams": [

    ],
    "labels": [

    ],
    "milestone": null,
    "commits_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127/commits",
    "review_comments_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127/comments",
    "review_comment_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls/comments{/number}",
    "comments_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/127/comments",
    "statuses_url": "https://api.github.com/repos/git-for-windows/build-extra/statuses/3bf75329d4ff9c0d52276f3f79110973c6c1167a",
    "head": {
      "label": "git-for-windows:master",
      "ref": "master",
      "sha": "3bf75329d4ff9c0d52276f3f79110973c6c1167a",
      "user": {
        "login": "git-for-windows",
        "id": 4571183,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
        "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/git-for-windows",
        "html_url": "https://github.com/git-for-windows",
        "followers_url": "https://api.github.com/users/git-for-windows/followers",
        "following_url": "https://api.github.com/users/git-for-windows/following{/other_user}",
        "gists_url": "https://api.github.com/users/git-for-windows/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/git-for-windows/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/git-for-windows/subscriptions",
        "organizations_url": "https://api.github.com/users/git-for-windows/orgs",
        "repos_url": "https://api.github.com/users/git-for-windows/repos",
        "events_url": "https://api.github.com/users/git-for-windows/events{/privacy}",
        "received_events_url": "https://api.github.com/users/git-for-windows/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 31306459,
        "node_id": "MDEwOlJlcG9zaXRvcnkzMTMwNjQ1OQ==",
        "name": "build-extra",
        "full_name": "git-for-windows/build-extra",
        "owner": {
          "login": "git-for-windows",
          "id": 4571183,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
          "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/git-for-windows",
          "html_url": "https://github.com/git-for-windows",
          "followers_url": "https://api.github.com/users/git-for-windows/followers",
          "following_url": "https://api.github.com/users/git-for-windows/following{/other_user}",
          "gists_url": "https://api.github.com/users/git-for-windows/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/git-for-windows/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/git-for-windows/subscriptions",
          "organizations_url": "https://api.github.com/users/git-for-windows/orgs",
          "repos_url": "https://api.github.com/users/git-for-windows/repos",
          "events_url": "https://api.github.com/users/git-for-windows/events{/privacy}",
          "received_events_url": "https://api.github.com/users/git-for-windows/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "private": false,
        "html_url": "https://github.com/git-for-windows/build-extra",
        "description": "Additional files and scripts to help build Git for Windows on MSYS2.",
        "fork": false,
        "url": "https://api.github.com/repos/git-for-windows/build-extra",
        "forks_url": "https://api.github.com/repos/git-for-windows/build-extra/forks",
        "keys_url": "https://api.github.com/repos/git-for-windows/build-extra/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/git-for-windows/build-extra/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/git-for-windows/build-extra/teams",
        "hooks_url": "https://api.github.com/repos/git-for-windows/build-extra/hooks",
        "issue_events_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/events{/number}",
        "events_url": "https://api.github.com/repos/git-for-windows/build-extra/events",
        "assignees_url": "https://api.github.com/repos/git-for-windows/build-extra/assignees{/user}",
        "branches_url": "https://api.github.com/repos/git-for-windows/build-extra/branches{/branch}",
        "tags_url": "https://api.github.com/repos/git-for-windows/build-extra/tags",
        "blobs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/git-for-windows/build-extra/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/git-for-windows/build-extra/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/git-for-windows/build-extra/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/git-for-windows/build-extra/languages",
        "stargazers_url": "https://api.github.com/repos/git-for-windows/build-extra/stargazers",
        "contributors_url": "https://api.github.com/repos/git-for-windows/build-extra/contributors",
        "subscribers_url": "https://api.github.com/repos/git-for-windows/build-extra/subscribers",
        "subscription_url": "https://api.github.com/repos/git-for-windows/build-extra/subscription",
        "commits_url": "https://api.github.com/repos/git-for-windows/build-extra/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/git-for-windows/build-extra/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/git-for-windows/build-extra/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/git-for-windows/build-extra/contents/{+path}",
        "compare_url": "https://api.github.com/repos/git-for-windows/build-extra/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/git-for-windows/build-extra/merges",
        "archive_url": "https://api.github.com/repos/git-for-windows/build-extra/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/git-for-windows/build-extra/downloads",
        "issues_url": "https://api.github.com/repos/git-for-windows/build-extra/issues{/number}",
        "pulls_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/git-for-windows/build-extra/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/git-for-windows/build-extra/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/git-for-windows/build-extra/labels{/name}",
        "releases_url": "https://api.github.com/repos/git-for-windows/build-extra/releases{/id}",
        "deployments_url": "https://api.github.com/repos/git-for-windows/build-extra/deployments",
        "created_at": "2015-02-25T09:34:52Z",
        "updated_at": "2018-08-21T12:48:12Z",
        "pushed_at": "2018-08-21T20:38:09Z",
        "git_url": "git://github.com/git-for-windows/build-extra.git",
        "ssh_url": "git@github.com:git-for-windows/build-extra.git",
        "clone_url": "https://github.com/git-for-windows/build-extra.git",
        "svn_url": "https://github.com/git-for-windows/build-extra",
        "homepage": "",
        "size": 14560,
        "stargazers_count": 204,
        "watchers_count": 204,
        "language": "Shell",
        "has_issues": false,
        "has_projects": false,
        "has_downloads": true,
        "has_wiki": false,
        "has_pages": false,
        "forks_count": 267,
        "mirror_url": null,
        "archived": false,
        "open_issues_count": 2,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": null,
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 267,
        "open_issues": 2,
        "watchers": 204,
        "default_branch": "master"
      }
    },
    "base": {
      "label": "git-for-windows:silent-install",
      "ref": "silent-install",
      "sha": "019fcec6e733e1ef4d265484319b7a5ba8cf2679",
      "user": {
        "login": "git-for-windows",
        "id": 4571183,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
        "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/git-for-windows",
        "html_url": "https://github.com/git-for-windows",
        "followers_url": "https://api.github.com/users/git-for-windows/followers",
        "following_url": "https://api.github.com/users/git-for-windows/following{/other_user}",
        "gists_url": "https://api.github.com/users/git-for-windows/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/git-for-windows/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/git-for-windows/subscriptions",
        "organizations_url": "https://api.github.com/users/git-for-windows/orgs",
        "repos_url": "https://api.github.com/users/git-for-windows/repos",
        "events_url": "https://api.github.com/users/git-for-windows/events{/privacy}",
        "received_events_url": "https://api.github.com/users/git-for-windows/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 31306459,
        "node_id": "MDEwOlJlcG9zaXRvcnkzMTMwNjQ1OQ==",
        "name": "build-extra",
        "full_name": "git-for-windows/build-extra",
        "owner": {
          "login": "git-for-windows",
          "id": 4571183,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
          "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/git-for-windows",
          "html_url": "https://github.com/git-for-windows",
          "followers_url": "https://api.github.com/users/git-for-windows/followers",
          "following_url": "https://api.github.com/users/git-for-windows/following{/other_user}",
          "gists_url": "https://api.github.com/users/git-for-windows/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/git-for-windows/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/git-for-windows/subscriptions",
          "organizations_url": "https://api.github.com/users/git-for-windows/orgs",
          "repos_url": "https://api.github.com/users/git-for-windows/repos",
          "events_url": "https://api.github.com/users/git-for-windows/events{/privacy}",
          "received_events_url": "https://api.github.com/users/git-for-windows/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "private": false,
        "html_url": "https://github.com/git-for-windows/build-extra",
        "description": "Additional files and scripts to help build Git for Windows on MSYS2.",
        "fork": false,
        "url": "https://api.github.com/repos/git-for-windows/build-extra",
        "forks_url": "https://api.github.com/repos/git-for-windows/build-extra/forks",
        "keys_url": "https://api.github.com/repos/git-for-windows/build-extra/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/git-for-windows/build-extra/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/git-for-windows/build-extra/teams",
        "hooks_url": "https://api.github.com/repos/git-for-windows/build-extra/hooks",
        "issue_events_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/events{/number}",
        "events_url": "https://api.github.com/repos/git-for-windows/build-extra/events",
        "assignees_url": "https://api.github.com/repos/git-for-windows/build-extra/assignees{/user}",
        "branches_url": "https://api.github.com/repos/git-for-windows/build-extra/branches{/branch}",
        "tags_url": "https://api.github.com/repos/git-for-windows/build-extra/tags",
        "blobs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/git-for-windows/build-extra/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/git-for-windows/build-extra/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/git-for-windows/build-extra/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/git-for-windows/build-extra/languages",
        "stargazers_url": "https://api.github.com/repos/git-for-windows/build-extra/stargazers",
        "contributors_url": "https://api.github.com/repos/git-for-windows/build-extra/contributors",
        "subscribers_url": "https://api.github.com/repos/git-for-windows/build-extra/subscribers",
        "subscription_url": "https://api.github.com/repos/git-for-windows/build-extra/subscription",
        "commits_url": "https://api.github.com/repos/git-for-windows/build-extra/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/git-for-windows/build-extra/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/git-for-windows/build-extra/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/git-for-windows/build-extra/contents/{+path}",
        "compare_url": "https://api.github.com/repos/git-for-windows/build-extra/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/git-for-windows/build-extra/merges",
        "archive_url": "https://api.github.com/repos/git-for-windows/build-extra/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/git-for-windows/build-extra/downloads",
        "issues_url": "https://api.github.com/repos/git-for-windows/build-extra/issues{/number}",
        "pulls_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/git-for-windows/build-extra/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/git-for-windows/build-extra/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/git-for-windows/build-extra/labels{/name}",
        "releases_url": "https://api.github.com/repos/git-for-windows/build-extra/releases{/id}",
        "deployments_url": "https://api.github.com/repos/git-for-windows/build-extra/deployments",
        "created_at": "2015-02-25T09:34:52Z",
        "updated_at": "2018-08-21T12:48:12Z",
        "pushed_at": "2018-08-21T20:38:09Z",
        "git_url": "git://github.com/git-for-windows/build-extra.git",
        "ssh_url": "git@github.com:git-for-windows/build-extra.git",
        "clone_url": "https://github.com/git-for-windows/build-extra.git",
        "svn_url": "https://github.com/git-for-windows/build-extra",
        "homepage": "",
        "size": 14560,
        "stargazers_count": 204,
        "watchers_count": 204,
        "language": "Shell",
        "has_issues": false,
        "has_projects": false,
        "has_downloads": true,
        "has_wiki": false,
        "has_pages": false,
        "forks_count": 267,
        "mirror_url": null,
        "archived": false,
        "open_issues_count": 2,
        "license": {
          "key": "other",
          "name": "Other",
          "spdx_id": null,
          "url": null,
          "node_id": "MDc6TGljZW5zZTA="
        },
        "forks": 267,
        "open_issues": 2,
        "watchers": 204,
        "default_branch": "master"
      }
    },
    "_links": {
      "self": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127"
      },
      "html": {
        "href": "https://github.com/git-for-windows/build-extra/pull/127"
      },
      "issue": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/issues/127"
      },
      "comments": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/issues/127/comments"
      },
      "review_comments": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127/comments"
      },
      "review_comment": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/pulls/comments{/number}"
      },
      "commits": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/pulls/127/commits"
      },
      "statuses": {
        "href": "https://api.github.com/repos/git-for-windows/build-extra/statuses/3bf75329d4ff9c0d52276f3f79110973c6c1167a"
      }
    },
    "author_association": "NONE",
    "merged": false,
    "mergeable": null,
    "rebaseable": null,
    "mergeable_state": "unknown",
    "merged_by": null,
    "comments": 0,
    "review_comments": 0,
    "maintainer_can_modify": false,
    "commits": 2119,
    "additions": 34529,
    "deletions": 7635,
    "changed_files": 297
  },
  "before": "a2ef00d3f46c4d660f84c15c7906891c70cde2f5",
  "after": "3bf75329d4ff9c0d52276f3f79110973c6c1167a",
  "repository": {
    "id": 31306459,
    "node_id": "MDEwOlJlcG9zaXRvcnkzMTMwNjQ1OQ==",
    "name": "build-extra",
    "full_name": "git-for-windows/build-extra",
    "owner": {
      "login": "git-for-windows",
      "id": 4571183,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
      "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/git-for-windows",
      "html_url": "https://github.com/git-for-windows",
      "followers_url": "https://api.github.com/users/git-for-windows/followers",
      "following_url": "https://api.github.com/users/git-for-windows/following{/other_user}",
      "gists_url": "https://api.github.com/users/git-for-windows/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/git-for-windows/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/git-for-windows/subscriptions",
      "organizations_url": "https://api.github.com/users/git-for-windows/orgs",
      "repos_url": "https://api.github.com/users/git-for-windows/repos",
      "events_url": "https://api.github.com/users/git-for-windows/events{/privacy}",
      "received_events_url": "https://api.github.com/users/git-for-windows/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "private": false,
    "html_url": "https://github.com/git-for-windows/build-extra",
    "description": "Additional files and scripts to help build Git for Windows on MSYS2.",
    "fork": false,
    "url": "https://api.github.com/repos/git-for-windows/build-extra",
    "forks_url": "https://api.github.com/repos/git-for-windows/build-extra/forks",
    "keys_url": "https://api.github.com/repos/git-for-windows/build-extra/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/git-for-windows/build-extra/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/git-for-windows/build-extra/teams",
    "hooks_url": "https://api.github.com/repos/git-for-windows/build-extra/hooks",
    "issue_events_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/events{/number}",
    "events_url": "https://api.github.com/repos/git-for-windows/build-extra/events",
    "assignees_url": "https://api.github.com/repos/git-for-windows/build-extra/assignees{/user}",
    "branches_url": "https://api.github.com/repos/git-for-windows/build-extra/branches{/branch}",
    "tags_url": "https://api.github.com/repos/git-for-windows/build-extra/tags",
    "blobs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/git-for-windows/build-extra/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/git-for-windows/build-extra/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/git-for-windows/build-extra/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/git-for-windows/build-extra/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/git-for-windows/build-extra/languages",
    "stargazers_url": "https://api.github.com/repos/git-for-windows/build-extra/stargazers",
    "contributors_url": "https://api.github.com/repos/git-for-windows/build-extra/contributors",
    "subscribers_url": "https://api.github.com/repos/git-for-windows/build-extra/subscribers",
    "subscription_url": "https://api.github.com/repos/git-for-windows/build-extra/subscription",
    "commits_url": "https://api.github.com/repos/git-for-windows/build-extra/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/git-for-windows/build-extra/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/git-for-windows/build-extra/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/git-for-windows/build-extra/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/git-for-windows/build-extra/contents/{+path}",
    "compare_url": "https://api.github.com/repos/git-for-windows/build-extra/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/git-for-windows/build-extra/merges",
    "archive_url": "https://api.github.com/repos/git-for-windows/build-extra/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/git-for-windows/build-extra/downloads",
    "issues_url": "https://api.github.com/repos/git-for-windows/build-extra/issues{/number}",
    "pulls_url": "https://api.github.com/repos/git-for-windows/build-extra/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/git-for-windows/build-extra/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/git-for-windows/build-extra/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/git-for-windows/build-extra/labels{/name}",
    "releases_url": "https://api.github.com/repos/git-for-windows/build-extra/releases{/id}",
    "deployments_url": "https://api.github.com/repos/git-for-windows/build-extra/deployments",
    "created_at": "2015-02-25T09:34:52Z",
    "updated_at": "2018-08-21T12:48:12Z",
    "pushed_at": "2018-08-21T20:38:09Z",
    "git_url": "git://github.com/git-for-windows/build-extra.git",
    "ssh_url": "git@github.com:git-for-windows/build-extra.git",
    "clone_url": "https://github.com/git-for-windows/build-extra.git",
    "svn_url": "https://github.com/git-for-windows/build-extra",
    "homepage": "",
    "size": 14560,
    "stargazers_count": 204,
    "watchers_count": 204,
    "language": "Shell",
    "has_issues": false,
    "has_projects": false,
    "has_downloads": true,
    "has_wiki": false,
    "has_pages": false,
    "forks_count": 267,
    "mirror_url": null,
    "archived": false,
    "open_issues_count": 2,
    "license": {
      "key": "other",
      "name": "Other",
      "spdx_id": null,
      "url": null,
      "node_id": "MDc6TGljZW5zZTA="
    },
    "forks": 267,
    "open_issues": 2,
    "watchers": 204,
    "default_branch": "master"
  },
  "organization": {
    "login": "git-for-windows",
    "id": 4571183,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjQ1NzExODM=",
    "url": "https://api.github.com/orgs/git-for-windows",
    "repos_url": "https://api.github.com/orgs/git-for-windows/repos",
    "events_url": "https://api.github.com/orgs/git-for-windows/events",
    "hooks_url": "https://api.github.com/orgs/git-for-windows/hooks",
    "issues_url": "https://api.github.com/orgs/git-for-windows/issues",
    "members_url": "https://api.github.com/orgs/git-for-windows/members{/member}",
    "public_members_url": "https://api.github.com/orgs/git-for-windows/public_members{/member}",
    "avatar_url": "https://avatars3.githubusercontent.com/u/4571183?v=4",
    "description": ""
  },
  "sender": {
    "login": "dscho",
    "id": 127790,
    "node_id": "MDQ6VXNlcjEyNzc5MA==",
    "avatar_url": "https://avatars0.githubusercontent.com/u/127790?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/dscho",
    "html_url": "https://github.com/dscho",
    "followers_url": "https://api.github.com/users/dscho/followers",
    "following_url": "https://api.github.com/users/dscho/following{/other_user}",
    "gists_url": "https://api.github.com/users/dscho/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/dscho/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/dscho/subscriptions",
    "organizations_url": "https://api.github.com/users/dscho/orgs",
    "repos_url": "https://api.github.com/users/dscho/repos",
    "events_url": "https://api.github.com/users/dscho/events{/privacy}",
    "received_events_url": "https://api.github.com/users/dscho/received_events",
    "type": "User",
    "site_admin": false
  }
}