Skip to content

Tweaks n improvements#68

Open
mborrus wants to merge 4 commits intodcstats:2.1.3from
mborrus:tweaks-n-improvements
Open

Tweaks n improvements#68
mborrus wants to merge 4 commits intodcstats:2.1.3from
mborrus:tweaks-n-improvements

Conversation

@mborrus
Copy link
Copy Markdown

@mborrus mborrus commented Apr 2, 2026

CI/CD:

  • tests on tests/ + /src
  • bump actions version
  • Drop mypy from CI (only pytest + flake8 remain)
  • add flake8 linting

Core utils (cbbpy_utils.py):

  • return empty df's instead of Nones to prevent downstream errors when empty
  • some other errors handling
  • extract team helpers to be make more modular
  • consolidate json extraction logic
  • cache csv reads

Data

  • Add New Haven Chargers (2026, NEC) to both mens_team_map.csv and womens_team_map.csv

Tests (tests/test_utils.py)

  • 184 lines of unit tests covering: _parse_date, _get_current_season, _get_team_map (including cache verification), _get_id_from_team, _get_season_conferences, _get_teams_from_conference, and all three boxscore helper
    functions

@mborrus
Copy link
Copy Markdown
Author

mborrus commented Apr 2, 2026

last commit adds de-duplification, improved regex extraction of players, tighter tests, defensive bounds checks on stats list

@mborrus mborrus marked this pull request as ready for review April 2, 2026 15:31
@dcstats
Copy link
Copy Markdown
Owner

dcstats commented Apr 3, 2026

@mborrus amazing I will take a look at this as soon as i get some time, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants