Skip to content

Refactor header and make playwright header tests work again #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dynamictulip wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor header and make playwright header tests work again #184

dynamictulip wants to merge 3 commits into from

Conversation

@dynamictulip
Copy link
Member

@dynamictulip dynamictulip commented Dec 20, 2025

  • Refactor header to remove duplication (cherry picked from nice-navbar branch
  • Make header logo link more accessible by setting the alt text on the image to the destination of the link (see https://www.w3.org/WAI/tutorials/images/functional/)
  • Fix playwright logo link nav tests to use the new logo link selector (rather than a really old one)

@vercel
Copy link

vercel bot commented Dec 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
dddsw-web Ready Ready Preview Dec 20, 2025 1:27pm

@dynamictulip dynamictulip linked an issue Dec 20, 2025 that may be closed by this pull request
Make Playwright tests pass again #183
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russdaygh russdaygh russdaygh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Playwright tests pass again

3 participants

@dynamictulip @russdaygh