Add PdoReader #126
Merged
Add PdoReader #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like this fails on PHP 5.3.. I can remove the |
Owner
|
Thanks! Please make the code PHP 5.3 compatible (for now). And could you add a note to the docs, too? |
rjmackay
force-pushed
the
add-pdo-reader
branch
from
b77cca7 to
341c726
Compare
rjmackay
force-pushed
the
add-pdo-reader
branch
from
341c726 to
ef9bf02
Compare
Contributor
Author
|
Updated.. but I have no idea why the tests are failing.. they pass fine for me locally. |
Collaborator
There was a problem hiding this comment.
can you set this column to autoincrement to pass the tests?
…balReader" This reverts commit df871d1.
Collaborator
|
@rjmackay Are you still working on it? |
Contributor
Author
|
I've had to shelve it while I continue on other work. |
Conflicts: tests/Ddeboer/DataImport/Tests/Reader/PdoReaderTest.php
Contributor
Author
|
Excellent finally got a test pass. @Baachi any other changes needed? |
Owner
|
Looks good! Can you add a short entry for this reader to the docs (README.md)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PdoReader class and unit tests.
Roughly copied from DBAL reader. I needed a simple DB reader that doesn't require DBAL.