Skip to content

Add table and plot download button for csv, png, svg, html#420

Open
joehart2001 wants to merge 12 commits intomainfrom
save-tables-2
Open

Add table and plot download button for csv, png, svg, html#420
joehart2001 wants to merge 12 commits intomainfrom
save-tables-2

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

@joehart2001 joehart2001 commented Mar 10, 2026

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

Created a better way of doing table downloads which uses less code + added plot downlaods

TODO: (maybe in another PR) asset downlaods e.g. phonon dispersions, diatomics etc and maybe structure downlaods?

Linked issue

Resolves #218

Testing

@joehart2001 joehart2001 added the enhancement New feature or request label Mar 10, 2026
Comment thread ml_peg/app/utils/register_callbacks.py Outdated
@alinelena alinelena requested a review from ElliottKasoar March 12, 2026 15:21
@ElliottKasoar ElliottKasoar changed the title download button for csv, png, svg - attempt 2 Add download button for csv, png, svg Apr 30, 2026
Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really well!

So does this only make it possible to download tables, and not the plots etc? Is there a way we could extend it to the full set of test/category outputs?

Comment thread .gitignore Outdated
Comment thread ml_peg/app/data/table_download/controls.css
@joehart2001 joehart2001 changed the title Add download button for csv, png, svg Add table and plot download button for csv, png, svg, html Apr 30, 2026
@joehart2001
Copy link
Copy Markdown
Collaborator Author

@ElliottKasoar opinions on structure downloads? we can do images but maybe even xyz files too. could be cool but can come under the asset download PR

@ElliottKasoar
Copy link
Copy Markdown
Collaborator

@ElliottKasoar opinions on structure downloads? we can do images but maybe even xyz files too. could be cool but can come under the asset download PR

WEAS should have some sort of download option: superstar54/weas-widget#13 / https://weas-widget.readthedocs.io/en/latest/gui.html#buttons

We may just need to enable the GUI?

Then I agree being able to download the file itself would be nice.

Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/app/utils/build_callbacks.py Outdated
Comment thread ml_peg/app/utils/register_callbacks.py Outdated
joehart2001 and others added 2 commits May 3, 2026 18:25
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

download table data

2 participants