Skip to content

Add colour scheme customisation #507

Open
joehart2001 wants to merge 9 commits intomainfrom
table-colour
Open

Add colour scheme customisation #507
joehart2001 wants to merge 9 commits intomainfrom
table-colour

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

@joehart2001 joehart2001 commented Apr 28, 2026

…een/red theme

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

update table colour from viridis_r to RdYlGn_r

  • goes with good/bad thresholds
  • more intuiative
  • more unique and less like other frameworks

As this is on the topic with thresholds, ive added:

  • matching threshold box outer to the colour scheme
  • preserve direction of initially set good and bad thresholds: if we set in metric.yml good > bad then try to change bad > good in the app, the good threshold will change to be the bad threshold + our smallest increment (as them being the same doesnt make sense)
  • the above also fixes an issue we had when we set good=bad

Linked issue

Resolves #518 #517

Testing

Copy link
Copy Markdown
Collaborator

@ElliottKasoar ElliottKasoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

The text on yellow for red-green is quite hard to read:

Image

Also, is the selection supposed to persist between visits? It doesn't seem to, but it probably makes sense if it does?

@ElliottKasoar ElliottKasoar added the enhancement New feature or request label Apr 30, 2026
@joehart2001
Copy link
Copy Markdown
Collaborator Author

This is nice!

The text on yellow for red-green is quite hard to read:

Image Also, is the selection supposed to persist between visits? It doesn't seem to, but it probably makes sense if it does?

ok yep agree, i hadnt thought of doing that. text wise should be the same way we do for swithcing from white to black for the viidiris table

@ElliottKasoar
Copy link
Copy Markdown
Collaborator

As suggested by @alinelena, let's change the threshold box colours to match this too?

@ElliottKasoar ElliottKasoar changed the title update table colour from viridis_r to RdYlGn_r Add colour scheme customisation May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix direction of thresholds based on original defined direction

2 participants