Skip to content

add elastic tensor voigt form check and conversion if needed#522

Open
joehart2001 wants to merge 3 commits intomainfrom
fix-elasticity
Open

add elastic tensor voigt form check and conversion if needed#522
joehart2001 wants to merge 3 commits intomainfrom
fix-elasticity

Conversation

@joehart2001
Copy link
Copy Markdown
Collaborator

@joehart2001 joehart2001 commented May 2, 2026

Pre-review checklist for PR author

PR author must check the checkboxes below when creating the PR.

Summary

For some models, matcalc returns the tensor as a plain 
numpy.ndarray with shape (3, 3, 3, 3), not as a pymatgen 
tensor object. NumPy arrays do not have .voigt, so the 
final dataframe conversion fails -> we need to be robust to this

@Fraser-Birks i can't add you as a reviewer but would be good to scan over, thanks!

Linked issue

Resolves #

Testing

ran elas benchmark

@joehart2001 joehart2001 requested a review from ElliottKasoar May 2, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant