Conversation
Uses `@functools.cache` on `get_framework_config` and `@lru_cache(maxsize=1)` on `load_framework_registry` to significantly speed up retrieval of framework configurations, while preventing cache mutations via `copy.deepcopy()`. Co-authored-by: alinelena <3306823+alinelena@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Cached
load_framework_registryusing@lru_cache(maxsize=1)and cachedget_framework_configusing@functools.cache. Usedcopy.deepcopyonly on the returned entry inget_framework_configto prevent dictionary mutation in the cache without copying the entire registry.🎯 Why:
yaml.safe_loadon large configuration files (frameworks.yml) is slow and it's called repeatedly throughout the application's lifecycle, blocking the main thread and causing slow table/badge generation.📊 Impact: Over 600x faster performance for accessing framework configurations (e.g., from ~1.17s to ~0.0018s per 1000 calls).
🔬 Measurement: Observe the time taken by
get_framework_configusing a basic profiler loop.PR created automatically by Jules for task 15163365029503033032 started by @alinelena