Move UNUSED out of C++11-dependent #ifdef#4
Merged
sorenhein merged 1 commit intodds-bridge:developfrom Nov 26, 2014
Merged
Conversation
hostilefork
force-pushed
the
better-unused
branch
from
417267f to
2cda0b8
Compare
hostilefork
force-pushed
the
better-unused
branch
from
2cda0b8 to
6144d52
Compare
sorenhein
added a commit
that referenced
this pull request
Nov 26, 2014
Move UNUSED out of C++11-dependent #ifdef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code says:
But that isn't true. nullptr is explicitly provided, however, in C++11.
What is true is that there are a bunch of codebases that define this exact macro somewhere. But it should not be necessary to write it conditionally for MS compilers.
In a technical sense, the name USE may be better. The reason is because UNUSED might end up being a lie--there's nothing stopping one from later adding a reference to the so-called UNUSED thing, no error will be caused.