Conversation
|
I think the code that determines the amount of free memory (Memory.cpp:228) may be the issue. On my system (Debian 9) it produces 0. Note that the full output of Mem: 16198028 5259516 808524 173588 10129988 10428852 The output format was changed about 4 years ago: https://gitlab.com/procps-ng/procps/commit/f47001c9e91a1e9b12db4497051a212cf49a87b1 |
Contributor
|
See #88. |
Contributor
|
Thanks. It did fix your issue, but it seems that rimmington fixed some larger issues that included yours, so I've gone with his pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merely loading libdds.so on Ubuntu crashes the parent program on exit. To repro, run the following python command:
I chased it down to trying to release memory on exit. It looks like the logic behind freeing the memory is broken, when the thread count is less than what's in the array. One might argue that this fix fixes the symptom, but it's better to avoid accessing pointers blindly.
This fix fixes the problem only on 18.04. On 16.04 it seems we are hitting the following line from Memory.cpp:
From a quick inspection of the code, I expect to be similar issue. Haven't spent the time debugging it yet.