Skip to content

Fix default port to match Dockerfile (8080 -> 8000)#3

Merged
ddulic merged 2 commits intomainfrom
fix/dockerfile-ports
Mar 11, 2026
Merged

Fix default port to match Dockerfile (8080 -> 8000)#3
ddulic merged 2 commits intomainfrom
fix/dockerfile-ports

Conversation

@ddulic
Copy link
Copy Markdown
Owner

@ddulic ddulic commented Mar 11, 2026

Summary

  • The Dockerfile sets SUPERNOTE_PORT=8000 but config.py still defaulted to 8080, causing a mismatch when running outside Docker
  • Updates the ServerConfig.port default and the base_url docstring comment to reflect 8000

The Dockerfile already sets SUPERNOTE_PORT=8000 but the config.py default
was still 8080, causing a mismatch when running outside Docker.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
supernote/cli/server.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ddulic ddulic merged commit 2d6dfec into main Mar 11, 2026
4 checks passed
@ddulic ddulic deleted the fix/dockerfile-ports branch March 13, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant