feat(skills): phase protocol enforcement for orchestration skills#192
Merged
feat(skills): phase protocol enforcement for orchestration skills#192
Conversation
added 4 commits
April 22, 2026 11:42
Add four complementary enforcement mechanisms to make ORCHESTRATED pipeline phase compliance the path of least resistance: - Phase Protocol section in router with 5 rules (announce, produce, no silent skips, verify, scoped nesting) - Produces:/Requires: checkpoint variables on all 7 orch skills - Continuation Detection for plan:orch and implement:orch - Phase Completion Checklist on all 7 orch skills Structural tests validate checklist/phase count correspondence, annotation presence, and continuation detection placement.
…note Replace hardcoded orchSkills array with fs.readdir discovery of *:orch directories so new orch skills are automatically validated by phase protocol structural tests. Add Phase Protocol convention bullet to CLAUDE.md Key Conventions > Skills section.
Add explicit data-flow annotations to 12 command files (7 base + 5 teams variants) aligning them with the Phase Protocol convention shipped for orchestration skills. Each phase/step heading now documents its checkpoint variables — what it produces and what it requires — making data contracts visible and consistent across both execution paths. Add per-phase correspondence tests to ambient.test.ts that dynamically discover all command files, detect container headings, and verify every leaf phase has at least one annotation.
…nd validation tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
router/SKILL.mdwith 5 universal enforcement rules (announce, produce, no silent skips, verify, scoped nesting)Produces:/Requires:checkpoint variables to all 7 orchestration skills, creating data-flow dependencies between phasesplan:orch(refinement path for existing artifacts) andimplement:orch(re-validation path after manual fixes)pipeline:orchfor inner skill phase prefix formatAll changes are markdown-only (SKILL.md files) + test additions. No TypeScript CLI code changes.
Test plan
npm run buildsucceeds — skills distributed to all 17 pluginsnpm testpasses — 1064/1064 tests (0 failures)phase protocol structural validationtest suite passes all 5 assertionsdevflow initreinstalls updated skills.docs/design/artifact — verify continuation detection