fix: replace username with date range in card header#118
Merged
unhappychoice merged 4 commits intomainfrom Apr 7, 2026
Merged
Conversation
…o img - Remove @username from card header (already in ticker text) - Add dateRange (e.g. 'Mar 30 - Apr 5, 2026') computed from ISO week - Export CARD_HEIGHT for downstream use - Add height='48' to img in setup README to prevent shrinking - Regenerate example SVGs
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Extract isoWeekToMonday to deployer/week.ts for reuse and testability - Add boundary value tests: year boundaries (W1 2025/2026), W53 (2020), Jan 1 Monday (2024 W1), last week of year (W52 2026) - Fix render.test.ts mock to pass through real isoWeekToMonday - Verify card dateRange E2E: weekId -> isoWeekToMonday -> formatted output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
height="48"to<img>in setup README to prevent shrinking on narrow viewportsCARD_HEIGHTconstant