Skip to content

⚡ Bolt: Optimize input event handling in InputMonitor.swift#68

Merged
debugtheworldbot merged 2 commits intomainfrom
bolt/input-monitor-optimization-6950648986004046605
Feb 26, 2026
Merged

⚡ Bolt: Optimize input event handling in InputMonitor.swift#68
debugtheworldbot merged 2 commits intomainfrom
bolt/input-monitor-optimization-6950648986004046605

Conversation

@debugtheworldbot
Copy link
Copy Markdown
Owner

This PR optimizes the InputMonitor.handleEvent method in the macOS application to reduce overhead during high-frequency mouse movement events.

Changes:

  • Replaced the per-event closure allocation appIdentityProvider with a private helper method getAppIdentity(for:).
  • Introduced an early return for mouseMoved, leftMouseDragged, and rightMouseDragged events to bypass unnecessary logic (like checking appStatsEnabled or accessing StatsManager.shared when not needed).

This change aims to improve performance and reduce memory churn in the event loop.


PR created automatically by Jules for task 6950648986004046605 started by @debugtheworldbot

💡 What:
- Refactored `InputMonitor.handleEvent` to use a helper method `getAppIdentity` instead of allocating a closure on every event.
- Added a fast path for `mouseMoved` events to return early, skipping unnecessary `StatsManager` access and `AppIdentity` logic.

🎯 Why:
- `handleEvent` is called hundreds of times per second during mouse movement.
- Allocating a closure and accessing the singleton repeatedly adds unnecessary overhead and garbage collection pressure on the hot path.

📊 Impact:
- Reduces allocations per mouse move event.
- Slightly reduces CPU usage during heavy mouse activity.

🔬 Measurement:
- Verified code correctness via manual inspection.
- The change is purely an optimization of internal implementation details and does not affect functionality.

Co-authored-by: debugtheworldbot <62830430+debugtheworldbot@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @debugtheworldbot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces performance optimizations to the InputMonitor.handleEvent method in the macOS application. By refactoring the application identity lookup into a reusable helper and adding an early exit for frequent mouse movement events, the changes aim to reduce memory churn and improve overall event loop efficiency, particularly under high event loads.

Highlights

  • Performance Optimization: Refactored the appIdentityProvider closure into a dedicated private helper method getAppIdentity(for:) to reduce per-event allocation overhead.
  • Early Return for Mouse Events: Implemented an early return optimization for high-frequency mouse movement events (mouseMoved, leftMouseDragged, rightMouseDragged) to bypass unnecessary logic and improve efficiency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • KeyStats/InputMonitor.swift
    • Introduced a new private helper method getAppIdentity(for:) to centralize the logic for retrieving application identity.
    • Replaced the appIdentityProvider closure with direct calls to the new getAppIdentity(for:) method across various event handling cases.
    • Added an early return condition within handleEvent for mouse movement events (.mouseMoved, .leftMouseDragged, .rightMouseDragged) to directly invoke handleMouseMove and prevent further processing.
    • Removed the dedicated switch case for mouse movement events, as they are now handled by the early return.
Activity
  • The pull request was automatically created by Jules for task 6950648986004046605, initiated by @debugtheworldbot.
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a performance optimization for input event handling. The changes include replacing a closure allocation with a helper method and adding a fast path for high-frequency mouse movement events. These changes are well-implemented and should achieve the goal of reducing overhead. I have one minor suggestion to improve the readability of the code.

Comment thread KeyStats/InputMonitor.swift Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@debugtheworldbot debugtheworldbot merged commit 93bed10 into main Feb 26, 2026
@debugtheworldbot debugtheworldbot deleted the bolt/input-monitor-optimization-6950648986004046605 branch February 26, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant