Moved magrittr to Imports, and added the pipe in importFrom#3
Open
ColinFay wants to merge 1 commit intodecisionpatterns:masterfrom
Open
Moved magrittr to Imports, and added the pipe in importFrom#3ColinFay wants to merge 1 commit intodecisionpatterns:masterfrom
ColinFay wants to merge 1 commit intodecisionpatterns:masterfrom
Conversation
These changes allow to use the package without having to explicitely load the magrittr package. As this package doesn't work without having to library(magrittr) before, it makes sense to have magrittr listed in the dependecies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow using the package without having to explicitly load the magrittr package. As this package doesn't work without having to library(magrittr) before, it makes sense to have magrittr listed in the dependecies.
With the current version, if I open a fresh R session, the package doesn't work:
Created on 2019-01-09 by the reprex package (v0.2.1)
This problem is addressed in this PR :
(with the new version) :
Created on 2019-01-09 by the reprex package (v0.2.1)