Skip to content

Moved magrittr to Imports, and added the pipe in importFrom#3

Open
ColinFay wants to merge 1 commit intodecisionpatterns:masterfrom
ColinFay:master
Open

Moved magrittr to Imports, and added the pipe in importFrom#3
ColinFay wants to merge 1 commit intodecisionpatterns:masterfrom
ColinFay:master

Conversation

@ColinFay
Copy link

@ColinFay ColinFay commented Jan 9, 2019

These changes allow using the package without having to explicitly load the magrittr package. As this package doesn't work without having to library(magrittr) before, it makes sense to have magrittr listed in the dependecies.

With the current version, if I open a fresh R session, the package doesn't work:

library(backpipe)
mean %<% 1:5
#> Error in 1:5 %>% mean: could not find function "%>%"

Created on 2019-01-09 by the reprex package (v0.2.1)

This problem is addressed in this PR :

(with the new version) :

library(backpipe)
mean %<% 1:5
#> [1] 3

Created on 2019-01-09 by the reprex package (v0.2.1)

These changes allow to use the package without having to explicitely load the magrittr package. As this package doesn't work without having to library(magrittr) before, it makes sense to have magrittr listed in the dependecies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant