fix(dvcr): VMDK import error#2065
Merged
Merged
Conversation
5a2ea3f to
cc947e1
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
9a8f547 to
eff959a
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
eff959a to
4508e61
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Contributor
|
Workflow has started. The target step completed with status: cancelled. |
Contributor
|
Workflow has started. The target step completed with status: cancelled. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
diafour
reviewed
Mar 11, 2026
diafour
reviewed
Mar 11, 2026
diafour
reviewed
Mar 12, 2026
diafour
reviewed
Mar 12, 2026
diafour
reviewed
Mar 12, 2026
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
cd3460b to
cd1fe8a
Compare
diafour
approved these changes
Mar 16, 2026
This was referenced Mar 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with importing VMDK disk images into DVCR (Deckhouse Virtualization Container Registry).
Technical changes:
Early format detection: Modified
getImageInfo()to detect VMDK format by reading the first 10MB and checking the magic number usingimage.Header.Match().VMDK-specific processing: Implemented
getImageInfoVMDK()that creates a synthetic sparse VMDK file from:qemu-img info)TailBuffer implementation: Added ring buffer that efficiently stores only the last N bytes from a stream without keeping the entire file in memory.
Better error diagnostics: Changed
cmd.Output()tocmd.CombinedOutput()to capture stderr fromqemu-imgfor debugging.Separated processing paths:
getImageInfoVMDK()- for VMDK format using synthetic file approachgetImageInfoStandard()- for other formats (qcow2, iso, raw) using existing approachResource efficiency:
Why do we need it, and what problem does it solve?
Problem:
When importing VMDK disk images (especially
streamOptimizedformat commonly used in OVF/OVA exports from VMware), the import failed with error:What is the expected result?
VMDK images import successfully.
Checklist
Changelog entries