Skip to content

fix(livemigration): require force=true for AlwaysForced policy #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilrwx merged 1 commit into from
Mar 20, 2026
Merged

fix(livemigration): require force=true for AlwaysForced policy #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions images/virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,6 @@ func (h LifecycleHandler) syncOperationComplete(ctx context.Context, vmop *v1alp
}

func (h LifecycleHandler) isApplicableForLiveMigrationPolicy(vmop *v1alpha2.VirtualMachineOperation, vm *v1alpha2.VirtualMachine) (string, bool) {
// No problems if force flag is not specified.
if vmop.Spec.Force == nil {
return "", true
}

effectivePolicy, autoConverge, err := livemigration.CalculateEffectivePolicy(*vm, vmop)
if err != nil {
msg := fmt.Sprintf("Operation is invalid: %v", err)
Expand Down
4 changes: 2 additions & 2 deletions .../virtualization-artifact/pkg/controller/vmop/migration/internal/handler/lifecycle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@ var _ = Describe("LifecycleHandler", func() {
),

// AlwaysForced cases.
Entry("is ok for AlwaysForced and force=nil",
Entry("should become Failed for AlwaysForced and force=nil",
newVMOPEvictPending(),
v1alpha2.AlwaysForcedMigrationPolicy,
v1alpha2.VMOPPhasePending,
v1alpha2.VMOPPhaseFailed,
),
Entry("should become Failed for AlwaysForced and force=false",
newVMOPEvictPending(vmopbuilder.WithForce(ptr.To(false))),
Expand Down
4 changes: 2 additions & 2 deletions images/virtualization-artifact/pkg/livemigration/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ func CalculateEffectivePolicy(vm v1alpha2.VirtualMachine, vmop *v1alpha2.Virtual
return effectivePolicy, *autoConvergePtr, fmt.Errorf("force=true is not applicable for VM liveMigrationPolicy %s", effectivePolicy)
}
case v1alpha2.AlwaysForcedMigrationPolicy:
if vmop.Spec.Force != nil && !*vmop.Spec.Force {
return effectivePolicy, *autoConvergePtr, fmt.Errorf("force=false is not applicable for VM liveMigrationPolicy %s", effectivePolicy)
if vmop.Spec.Force == nil || !*vmop.Spec.Force {
return effectivePolicy, *autoConvergePtr, fmt.Errorf("force=true is required for VM liveMigrationPolicy %s", effectivePolicy)
}
}
}
Expand Down
Loading