refactor(hooks): discover kube feature gates via metrics endpoint#2137
Merged
yaroslavborbat merged 2 commits intoMar 24, 2026
Merged
Conversation
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Isteb4k
approved these changes
Mar 24, 2026
4 tasks
Isteb4k
pushed a commit
that referenced
this pull request
Mar 25, 2026
) refactor(hooks): discover kube feature gates via metrics endpoint --------- Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com> (cherry picked from commit 251313d)
This was referenced Mar 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored the
discover-kube-apiserver-feature-gateshook to discover enabled feature gatesby scraping the kube-apiserver
/metricsendpoint instead of parsing the kube-apiserver pod'scommand-line arguments (
--feature-gates=...).Key changes:
kube-apiserverpods and the associatedJqFiltersnapshot logic.fetchMetrics— fetches raw Prometheus metrics from/metricsvia the REST client.parseEnabledFeatureGates— parseskubernetes_feature_enabled{...} 1lines to extract enabled gate names.draFeatureGatesPathcondition:DRAResourceClaimDeviceStatuswas previously assumed always enabled; it is now explicitly checked.parseEnabledFeatureGatesand the full reconciliation flow with a mock HTTP server.Why do we need it, and what problem does it solve?
The previous implementation parsed the
--feature-gatesCLI flag from the kube-apiserver pod spec.This approach is fragile: it only captures explicitly set gates and misses all gates that are
enabled by default (i.e., those not listed in the flag). This caused incorrect detection of DRA
feature gates in environments where gates are enabled by default without being explicitly passed
to the API server.
The
/metricsendpoint exposeskubernetes_feature_enabledgauge for all known feature gates,including defaults, giving a complete and authoritative picture of what is actually enabled at runtime.
What is the expected result?
--feature-gates).virtualization.internal.kubeAPIServerFeatureGatesis correctly populated withall enabled gates.
virtualization.internal.hasDraFeatureGatesis set to"true"whenDRAResourceClaimDeviceStatus,DRADeviceBindingConditions, andDRAConsumableCapacityare all enabled.Checklist
Changelog entries