Skip to content

fix(vmop): prevent Maintenance mode from getting stuck during restore #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilrwx merged 3 commits into from
Mar 24, 2026
Merged

fix(vmop): prevent Maintenance mode from getting stuck during restore #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9530633
fix(vmop): prevent Maintenance mode from getting stuck during restore
danilrwx Mar 24, 2026
105669d
Merge branch 'main' into fix/vmop/maintenance-true-for-completed
danilrwx Mar 24, 2026
969875c
fix(vmop): set maintenance condition to false instead of early return
danilrwx Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...rtualization-artifact/pkg/controller/vmop/snapshot/internal/step/exit_maintenance_step.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ func (s ExitMaintenanceStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMac
)
return &reconcile.Result{}, err
}

maintenanceVMCondition.Status = metav1.ConditionFalse
}

// If the maintenance condition was not present on the VM,
Expand Down
2 changes: 1 addition & 1 deletion ...ualization-artifact/pkg/controller/vmop/snapshot/internal/step/waiting_disk_ready_step.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func (s WaitingDisksReadyStep) Take(ctx context.Context, vmop *v1alpha2.VirtualM
if k8serrors.IsNotFound(err) {
cb.Message("Waiting for resource readiness.")
conditions.SetCondition(cb, &vmop.Status.Conditions)
return nil, nil
return &reconcile.Result{}, nil
}
return &reconcile.Result{}, fmt.Errorf("failed to get the `VirtualDisk`: %w", err)
}
Expand Down
Loading