fix(vm): protect hp pod with new d8 label#2153
Merged
Merged
Conversation
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
2b19ec3 to
7398f23
Compare
Isteb4k
approved these changes
Mar 25, 2026
Merged
Isteb4k
pushed a commit
that referenced
this pull request
Mar 25, 2026
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com> (cherry picked from commit 54e3c29)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotplug pods (HP) must not be evicted — this is enforced via a webhook.
Bug: HP pods were labeled with
kubevirt.io=hotplug-disk, but the eviction webhook was checking forkubevirt.internal.virtualization.deckhouse.io=d8v-hotplug-disk. After renaming the label, the webhook was not updated, so eviction protection was not working. Fixed the label mismatch in the webhook and added an e2e test to cover this case.deckhouse/3p-kubevirt#83
Why do we need it, and what problem does it solve?
HP pods labeled with the old
kubevirt.iokey were not matched by the eviction webhook after the label was renamed tokubevirt.internal.virtualization.deckhouse.io=d8v-hotplug-disk. As a result, HP pods could be evicted unexpectedly, potentially disrupting hotplugged disk attachments.What is the expected result?
Checklist
Changelog entries