fix(vm): disconnecting Main network#2185
Merged
Merged
Conversation
This fixes a bug where disabling the Main network did not remove the cilium annotation from KVVMI. Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
eofff
approved these changes
Apr 3, 2026
Merged
fl64
pushed a commit
that referenced
this pull request
Apr 28, 2026
This fixes a bug where disabling the Main network did not remove the cilium annotation from KVVMI. Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com> Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Main network disconnection handling by removing the cilium IP request annotation from KVVMI when the Main network is disabled.
Why do we need it, and what problem does it solve?
When the Main network was disabled, the cilium-related annotation remained on the KVVMI object. This left stale networking metadata on the instance template and could lead to incorrect behavior after disconnecting the Main network.
What is the expected result?
Checklist
Changelog entries