Skip to content

fix(vm): disconnecting Main network#2185

Merged
LopatinDmitr merged 1 commit into
mainfrom
fix/vm/disconnecting-main-network
Apr 3, 2026
Merged

fix(vm): disconnecting Main network#2185
LopatinDmitr merged 1 commit into
mainfrom
fix/vm/disconnecting-main-network

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented Apr 3, 2026

Description

Fix Main network disconnection handling by removing the cilium IP request annotation from KVVMI when the Main network is disabled.

Why do we need it, and what problem does it solve?

When the Main network was disabled, the cilium-related annotation remained on the KVVMI object. This left stale networking metadata on the instance template and could lead to incorrect behavior after disconnecting the Main network.

What is the expected result?

  1. Create or update a VM so that the Main network is enabled and the cilium IP request annotation is present on KVVMI.
  2. Disable the Main network.
  3. Verify that the cilium annotation is removed from KVVMI.
  4. Verify that the VM no longer keeps stale Main network cilium metadata.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: "Fixed removal of the `Main` network from a virtual machine: the virtual machine no longer uses an IP address from the virtualization CIDR after the network is removed."

This fixes a bug where disabling the Main network did not remove the cilium annotation from KVVMI.

Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr added this to the v1.8.0 milestone Apr 3, 2026
@eofff eofff self-requested a review April 3, 2026 14:16
@LopatinDmitr LopatinDmitr merged commit e8eeaef into main Apr 3, 2026
37 of 40 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vm/disconnecting-main-network branch April 3, 2026 15:29
fl64 pushed a commit that referenced this pull request Apr 28, 2026
This fixes a bug where disabling the Main network did not remove the cilium annotation from KVVMI.

Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants