Skip to content

fix(ci): render nfs cluster#2228

Merged
universal-itengineer merged 1 commit into
mainfrom
fix/ci/fix-render-nfs
Apr 16, 2026
Merged

fix(ci): render nfs cluster#2228
universal-itengineer merged 1 commit into
mainfrom
fix/ci/fix-render-nfs

Conversation

@universal-itengineer
Copy link
Copy Markdown
Member

@universal-itengineer universal-itengineer commented Apr 16, 2026

Description

Fix the infra Helm template for the static DVP cluster setup so that NFS deployments render complete VirtualMachine specs.

Why do we need it, and what problem does it solve?

The current template places the if ne .Values.storageType "nfs" condition too broadly.
As a result, when storageType is set to nfs, the rendered master/worker VirtualMachine resources lose required fields such as CPU, memory, run policy, and VM class reference.

This breaks bootstrap for the NFS e2e pipeline and leads to admission webhook errors during VM creation, including validation failures like:

the specified ".spec.cpu.cores 0" value is not among the sizing policies allowed for the virtual machine

What is the expected result?

For storageType: nfs, the template should skip only NFS-incompatible parts such as additional disks, while still rendering a valid full VirtualMachine spec.

Steps to verify:

  1. Render test/dvp-static-cluster/charts/infra with storageType: nfs.
  2. Check the generated VirtualMachine manifests for master/worker nodes.
  3. Confirm they still contain required fields such as spec.cpu, spec.memory, spec.runPolicy, and spec.virtualMachineClassName.
  4. Apply the rendered manifests and verify that VM creation is no longer rejected by the admission webhook because of missing CPU configuration.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: fix
summary: "fix NFS infra Helm template rendering for e2e nested cluster bootstrap"

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer merged commit beb0152 into main Apr 16, 2026
22 of 23 checks passed
@universal-itengineer universal-itengineer deleted the fix/ci/fix-render-nfs branch April 16, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants