fix(ci): render nfs cluster#2228
Merged
Merged
Conversation
42d1464 to
63a63b2
Compare
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
63a63b2 to
3245b62
Compare
nevermarine
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the
infraHelm template for the static DVP cluster setup so that NFS deployments render completeVirtualMachinespecs.Why do we need it, and what problem does it solve?
The current template places the
if ne .Values.storageType "nfs"condition too broadly.As a result, when
storageTypeis set tonfs, the rendered master/workerVirtualMachineresources lose required fields such as CPU, memory, run policy, and VM class reference.This breaks bootstrap for the NFS e2e pipeline and leads to admission webhook errors during VM creation, including validation failures like:
the specified ".spec.cpu.cores 0" value is not among the sizing policies allowed for the virtual machineWhat is the expected result?
For
storageType: nfs, the template should skip only NFS-incompatible parts such as additional disks, while still rendering a valid fullVirtualMachinespec.Steps to verify:
test/dvp-static-cluster/charts/infrawithstorageType: nfs.VirtualMachinemanifests for master/worker nodes.spec.cpu,spec.memory,spec.runPolicy, andspec.virtualMachineClassName.Checklist
Changelog entries