fix(module): extend virtualization RBACv1/RBACv2 coverage#2276
Merged
Conversation
fl64
changed the title
Isteb4k
requested changes
Apr 28, 2026
| - virtualization.deckhouse.io | ||
| resources: | ||
| - virtualmachineoperations | ||
| - virtualmachinesnapshotoperations |
Contributor
There was a problem hiding this comment.
PrivilegedUser: The same as User + can exec into containers, read secrets, and delete pods (and thus, restart them).
It looks like it should also be able to delete virtual machines.
Member
Author
There was a problem hiding this comment.
it doesn't fit into the logic of VM operation
Contributor
There was a problem hiding this comment.
It doesn’t match the documentation at all. But I guess we can leave it like this for now
| - virtualization.deckhouse.io | ||
| resources: | ||
| - virtualmachineoperations | ||
| - virtualmachinesnapshotoperations |
Contributor
There was a problem hiding this comment.
virtualmachinesnapshotoperations will allow the user to create virtual machines. But a PrivilegedUser shouldn’t be able to do that
Member
Author
There was a problem hiding this comment.
yep
moved it to Editor and vmop too
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Isteb4k
approved these changes
Apr 28, 2026
Merged
Isteb4k
pushed a commit
that referenced
this pull request
Apr 28, 2026
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com> Extend virtualization RBAC coverage in both RBACv1 and RBACv2. The change adds missing permissions for: - virtualmachinemacaddresses - virtualmachinemacaddressleases - virtualmachinesnapshotoperations - nodeusbdevices It also introduces a separate RBACv2 capability for snapshot operations: d8:use:capability:virtualization:execute_virtualmachinesnapshot_operations (cherry picked from commit 3646dbe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend virtualization RBAC coverage in both RBACv1 and RBACv2.
The change adds missing permissions for:
virtualmachinemacaddressesvirtualmachinemacaddressleasesvirtualmachinesnapshotoperationsnodeusbdevicesIt also introduces a separate RBACv2 capability for snapshot operations:
d8:use:capability:virtualization:execute_virtualmachinesnapshot_operationsWhy do we need it, and what problem does it solve?
Some virtualization API resources were missing from module RBAC templates, and RBACv1/RBACv2 coverage was inconsistent.
What is the expected result?
Checklist
Changelog entries