Skip to content

fix(vm): preserve spec.blockDeviceRefs order in hotplug handler#2360

Merged
loktev-d merged 1 commit into
mainfrom
fix/vm/stable-hotplug-order
May 19, 2026
Merged

fix(vm): preserve spec.blockDeviceRefs order in hotplug handler#2360
loktev-d merged 1 commit into
mainfrom
fix/vm/stable-hotplug-order

Conversation

@loktev-d
Copy link
Copy Markdown
Contributor

@loktev-d loktev-d commented May 18, 2026

Description

Iterate over Spec.BlockDeviceRefs slice instead of map when hotplugging to preserve hotplug order.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: preserve spec.blockDeviceRefs order in hotplug handler

Signed-off-by: Daniil Loktev <lokt.daniil@gmail.com>
@loktev-d loktev-d marked this pull request as draft May 18, 2026 14:26
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label May 18, 2026
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 18, 2026

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 18, 2026
@loktev-d loktev-d added this to the v1.9.0 milestone May 19, 2026
@loktev-d loktev-d marked this pull request as ready for review May 19, 2026 15:31
@loktev-d loktev-d merged commit 5b1d19b into main May 19, 2026
78 of 88 checks passed
@loktev-d loktev-d deleted the fix/vm/stable-hotplug-order branch May 19, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants