fix(rbac): allow listing nodes for VM migration#2399
Open
danilrwx wants to merge 1 commit into
Open
Conversation
18c5b4e to
a0792f9
Compare
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com> fix(rbac): remove extra node get permission Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
a0792f9 to
75bf9c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Grant virtualization users permission to list and watch Kubernetes Nodes when executing virtual machine operations.
The Console migration dialog checks
canI({ resource: 'nodes' }, ['list', 'watch'])before enabling the "Migrate to the selected node" option and uses the node list to build available migration targets.Why do we need it, and what problem does it solve?
Users with VM operation permissions could initiate migration to an arbitrary node, but the Console disabled migration to a selected node with a "Not enough rights" tooltip because the role did not include Node list/watch permissions.
This fix aligns virtualization RBAC with the Console permission check and allows eligible users to select a target node for VM migration.
What is the expected result?
Checklist
Changelog entries