Skip to content

fix(rbac): allow listing nodes for VM migration#2399

Open
danilrwx wants to merge 1 commit into
mainfrom
fix/migration/not-enough-permissions-console
Open

fix(rbac): allow listing nodes for VM migration#2399
danilrwx wants to merge 1 commit into
mainfrom
fix/migration/not-enough-permissions-console

Conversation

@danilrwx
Copy link
Copy Markdown
Contributor

@danilrwx danilrwx commented May 25, 2026

Description

Grant virtualization users permission to list and watch Kubernetes Nodes when executing virtual machine operations.

The Console migration dialog checks canI({ resource: 'nodes' }, ['list', 'watch']) before enabling the "Migrate to the selected node" option and uses the node list to build available migration targets.

Why do we need it, and what problem does it solve?

Users with VM operation permissions could initiate migration to an arbitrary node, but the Console disabled migration to a selected node with a "Not enough rights" tooltip because the role did not include Node list/watch permissions.

This fix aligns virtualization RBAC with the Console permission check and allows eligible users to select a target node for VM migration.

What is the expected result?

  1. Open a running VM migration dialog in Console as a user with virtualization operation permissions.
  2. Verify that "Migrate to the selected node" is enabled outside CE edition.
  3. Select an available target node and start migration.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: fix
summary: Allow users with VM operation permissions to select a target node for virtual machine migration in Console.
impact_level: low

@danilrwx danilrwx marked this pull request as ready for review May 25, 2026 07:03
@danilrwx danilrwx requested a review from Isteb4k as a code owner May 25, 2026 07:03
@danilrwx danilrwx force-pushed the fix/migration/not-enough-permissions-console branch from 18c5b4e to a0792f9 Compare May 25, 2026 07:03
@danilrwx danilrwx added this to the v1.9.0 milestone May 25, 2026
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

fix(rbac): remove extra node get permission

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx danilrwx force-pushed the fix/migration/not-enough-permissions-console branch from a0792f9 to 75bf9c2 Compare May 25, 2026 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant