blockchain: Correct mempool view construction.#2232
Merged
davecgh merged 1 commit intoJun 27, 2020
Conversation
This corrects the construction of the view used by the mempool when dealing with disapproved blocks and includes new tests to ensure the various disapproval combinations work as intended.
dajohi
approved these changes
Jun 27, 2020
chappjc
approved these changes
Jun 27, 2020
Member
chappjc
left a comment
chappjc
left a comment
There was a problem hiding this comment.
Successfully synced 4 testnet nodes, and dcrdata, without issue.
matheusd
approved these changes
Jun 27, 2020
Member
matheusd
left a comment
matheusd
left a comment
There was a problem hiding this comment.
Verified FetchUtxoView() is only called by the mempool and block template generation code paths and otherwise doesn't cause side-effects in the Blockchain struct, so doesn't cause hard-forking consensus changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the construction of the view used by the
mempoolwhen dealing with disapproved blocks and includes new tests to ensure the various disapproval combinations work as intended.It does not affect consensus code.