netsync: Request new headers on rejected tip. #3302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the sync manager to immediately request new headers from all peers in the event the block associated with the best target header is rejected. This allows alternative blocks to be downloaded more quickly without first having to wait for new blocks. While here, it also allows a couple of blocks of leeway when returning the manager to an unsynced state.
davecgh
force-pushed
the
netsync_req_hdrs_rej_best_block
branch
from
35156a8 to
1cf325b
Compare
jrick
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the sync manager to immediately request new headers from all peers in the event the block associated with the best target header is rejected. This allows alternative blocks to be downloaded more quickly without first having to wait for new blocks.
While here, it also allows a couple of blocks of leeway when returning the manager to an unsynced state.