[release-v2.0] main: Use backported peer updates. #3350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mixing message (implementing the WriteHash(hash.Hash) method) is read from another peer, it is improper to use its Hash() method before calculating and storing the hash using WriteHash. Do this as early as possible in readMessage in the peer package. This avoids the need for callers to remember to do this step manually in the OnMix* callbacks.
This includes the message hash and the sender's identity in the short human-readable description of peer messages as they are debug logged. While here and because mixing introduced a new inventory vector type, add it to the inv summary case statement.
This updates the 2.0 release branch to use the latest version of the peer module which includes updates to immediately hash mix messages when they are read from the wire and to include mix message summaries in the debug logging output. In particular, the following updated module version is used: - github.com/decred/dcrd/peer/v3@v3.1.1
jrick
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the 2.0 release branch to use the latest version of the
peermodule which includes updates to immediately hash mix messages when they are read from the wire and to include mix message summaries in the debug logging output.In particular, the following updated module version is used:
Note that it also cherry picks all of the commits included in updates to the
peer/v3module to ensure they are also included in the release branch even though it is not strictly necessary sincego.modhas been updated to require the newpeer/v3.1.1release and thus will pull in the new code. However, from past experience, not having code backported to modules available in the release branch too leads to headaches for devs building from source in their local workspace with overrides such as those ingo.work.