multi: btc clone refactor#497
Merged
Merged
Conversation
chappjc
requested changes
Jun 18, 2020
Member
chappjc
left a comment
chappjc
left a comment
There was a problem hiding this comment.
Nice dedup. Just a few suggestions.
Comment on lines
+34
to
+36
| // Net is not the standard for LTC simnet, since they never changed it | ||
| // from the BTC values and it must be unique. It's just random. | ||
| Net: 0x9acb0442, |
Member
There was a problem hiding this comment.
Interesting bit of trivia. Can we link to something explaining this or is this a sim/regnet thing for most coins?
Member
Author
There was a problem hiding this comment.
For us, the only place this is used is right here, and our only requirement is that it's unique to avoid ErrDuplicateNet. Should I add this explanation to the comment?
JoeGruffins
approved these changes
Jun 18, 2020
chappjc
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine and simplify a lot of code around btc clones.