dex/encode: empty pushes should load as nil#538
Closed
chappjc wants to merge 1 commit into
Closed
Conversation
chappjc
commented
Jul 8, 2020
| func (t *trackedTrade) isRedeemable(match *matchTracker) bool { | ||
| dbMatch, metaData, proof, _ := match.parts() | ||
| if match.failErr != nil || proof.RefundCoin != nil { | ||
| log.Debugf("failErr = %v, RefundCoin = %v", match.failErr, proof.RefundCoin) |
Member
Author
There was a problem hiding this comment.
Was showing [DBG] CORE: failErr = <nil>, RefundCoin = indicating proof.RefundCoin != nil, an empty but non-nil slice although it was nil when stored to the client DB. More logging == better.
With spew.Dump of the db.MetaMatches, I noticed many other fields, such as signatures and the secret, that were not nil but empty as well.
Comment on lines
+1888
to
+1890
| // for _, match := range matches { | ||
| // match.tracker.tick() | ||
| // } |
Member
Author
There was a problem hiding this comment.
We might want to tick right away instead of waiting for the ticker to fire.
| } | ||
|
|
||
| status := order.MatchStatus(msgMatch.Status) | ||
| log.Debugf("registering match %v for order %v in status %v", msgMatch.MatchID, oid, status) |
Member
Author
There was a problem hiding this comment.
Note that the server-side connect fixes in #531 are necessary for both match messages to be sent on connect.
chappjc
force-pushed
the
empty-pushes-nil
branch
from
54d7f98 to
bb845eb
Compare
Member
Author
|
Just letting #531 get these changes since there were a few more related commits in that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves inability to resume matches on dexc restart, maybe resolves #528.