client/core: fix incorrect fill amount when missing inactive matches#564
Closed
chappjc wants to merge 1 commit into
Closed
client/core: fix incorrect fill amount when missing inactive matches#564chappjc wants to merge 1 commit into
chappjc wants to merge 1 commit into
Conversation
…e matches When dexc is restarted with a partially filled order where the previous match(es) that partially filled the order are inactive, the fill amount computation in (*trackedTrade).negotiate was incorrect. This change adds the filled quantity for new matches rather than trying to recompute and set the whole match amount. (*trackedTrade).negotiate now attempts to process all matches even if one of them fails for some reason.
Member
|
LOL. I'm working on a solution for this today to. We can compare in a minute. |
Member
Author
|
Closing in favor of #566 since loading all the inactive matches for active orders has other potential benefits. I still prefer using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dexc is restarted with a partially filled order where the previous
match(es) that partially filled the order are inactive, the fill amount
computation in
(*trackedTrade).negotiatewas incorrect.This change adds the filled quantity for new matches rather than trying
to recompute and set the whole match amount.
(*trackedTrade).negotiatenow attempts to process all matches even ifone of them fails for some reason.