client/asset/dcr: use rawrequest for signrawtransaction to get Errors#590
Merged
chappjc merged 3 commits intoAug 17, 2020
Merged
Conversation
chappjc
force-pushed
the
rpcclient-signrawtransaction-debuglog
branch
from
f08d940 to
c3c4a7d
Compare
Member
|
I'm testing this with #589, will report with details if I encounter any more sign tx errors. |
chappjc
force-pushed
the
rpcclient-signrawtransaction-debuglog
branch
from
c3c4a7d to
495729b
Compare
chappjc
changed the title
Member
Author
|
I removed the rpcclient replace now that we have a RawRequest solution to inspect the |
chappjc
force-pushed
the
rpcclient-signrawtransaction-debuglog
branch
from
495729b to
f5f8b9f
Compare
Member
Author
|
Removed the retries since it seems like that the error is "wallet locked". |
chappjc
changed the title
itswisdomagain
approved these changes
Aug 14, 2020
Member
I'm not entirely sure that's the only possible reason for signrawtx errors but I'm not sure retrying multiple times will avert any other error either. Having more info in error logs will surely be helpful in tracking down any other possible cause of signtxerrors. |
JoeGruffins
approved these changes
Aug 17, 2020
buck54321
approved these changes
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses
RawRequestforsignrawtransaction, which allows inspecting thewalletjson.SignRawTransactionResult.Errorsfield, whichrpcclientdrops.ThesignTxfunction now retries 3 times with a 1/4 second delay between tries.