Hardcode in checks for block version and block 0 or 1 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ntACK, bit of a hack but should work fine for explorer purposes. |
Member
Author
|
Yah agree about the hack. I plan on adding a true params area to avoid the magic numbers. Will most likely begin on that PR next week. |
Member
|
Looks good to me. OK after you squash and give one combined commit message. |
If version = 0 then use testnet params, and for version = 1 use mainnet. Then check for blocks 0 and 1. Block 0 should show no reward. Block 1 should show the total premine value (100000 for testnet, 1680000 for mainnet)
alexlyp
force-pushed
the
ayp_fixblock01rewards
branch
from
5bc6fe2 to
6d50513
Compare
Member
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If version = 0 then use testnet params, and the same for version = 1 for mainnet.
Also check for blocks 0 and 1. Block 0 should show no reward and block 1 should show the total premine value (100000 for testnet, 1680000 for mainnet)