Skip to content

Conversation

@umesh-timalsina
Copy link
Contributor

@umesh-timalsina umesh-timalsina commented Mar 25, 2020

Initial Support for Scatter Plots. Closes #1394.

1. Update pipeline seed to incorporate scatterPoints (0.18.0)
2. Create metadata nodes for scatter plot support
3. Update backend_deepforge.py to include PathCollections
@brollb brollb changed the title Scatter Plots Support from Matpoltlib (Closes #1394) Scatter Plots Support from Matplotlib. Closes #1394 Mar 25, 2020
@brollb
Copy link
Contributor

brollb commented Mar 25, 2020

I was testing this with a simple scatterplot but was getting an empty figure. (I merged #1544 into the branch beforehand.)

import matplotlib.pyplot as plt

xs = list(range(0, 100))
y = [ 2*x for x in xs ]
plt.scatter(xs, y)
plt.show()

Any thoughts about the issue?

@umesh-timalsina
Copy link
Contributor Author

This branch is not ready for review yet.

@umesh-timalsina umesh-timalsina marked this pull request as ready for review March 25, 2020 23:29
@umesh-timalsina umesh-timalsina added the job feedback Graphs, images, and other feedback generated during job execution. label Mar 26, 2020
@umesh-timalsina umesh-timalsina added this to the 2.2.0 milestone Mar 26, 2020
@umesh-timalsina umesh-timalsina requested a review from brollb March 26, 2020 14:18
Copy link
Contributor

@brollb brollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added one optional comment inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

job feedback Graphs, images, and other feedback generated during job execution.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Scatter Plots

3 participants