Skip to content

Conversation

@xuyan213
Copy link

This driver provides kernel-side support for the Random Number Generator hardware found on Phytium SoCs.

This driver provides kernel-side support for the Random Number
Generator hardware found on Phytium SoCs.

Signed-off-by: xu yan <xuyan1481@phytium.com>
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_rng_read函数中,使用readl_poll_timeout可能导致资源泄露,因为如果readl函数返回错误,DELAYTIMEOUT参数将被忽略。
  • phytium_rng_read函数中的max变量应该是size_t类型,以匹配readl函数的返回类型。
  • phytium_rng_read函数中缺少对readl返回值的错误处理,可能会导致未检查的错误。
  • phytium_rng_initphytium_rng_cleanup函数中没有检查writelreadl是否成功,可能会导致未检查的错误。
  • module_param宏的使用应该检查返回值是否为0,以确保模块参数的设置成功。
  • dev_err函数在phytium_rng_read中被调用,但没有提供错误代码,不利于调试。

是否建议立即修改:

@Avenger-285714 Avenger-285714 merged commit 9a4741d into deepin-community:linux-6.6.y May 27, 2024
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 22, 2025
This driver provides kernel-side support for the Random Number
Generator hardware found on Phytium SoCs.

Signed-off-by: xu yan <xuyan1481@phytium.com>
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: deepin-community#149
(cherry picked from commit 720bcb4)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
lanlanxiyiji pushed a commit that referenced this pull request Dec 26, 2025
This driver provides kernel-side support for the Random Number
Generator hardware found on Phytium SoCs.

Signed-off-by: xu yan <xuyan1481@phytium.com>
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Link: #149
(cherry picked from commit 720bcb4)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants